Review TYPO3_4-5 Merged

3402[BUGFIX] TCA Tree should respect requestUpdate and type

Marco Huber CR +2 V +2 Easy +16 −1 updated 06/03/13, 20:49

Commit message

TCA Tree should respect $TCA['myTable']['ctrl']['requestUpdate']
and $TCA['myTable']['type'], but the onChange Javascript is missing.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Lars Trebing +1
  • Verified V +2
    • Jigal van Hemert +2
    • Lars Trebing +1

Issues 1

Files 1

Review log 8

  1. Steffen Ritter commented on patch set 1 08/28/11, 15:51

    Do not submit If you repush the change without changing the submodule pointer I will submit it right through as the change is the same as in master and there is noch difference in master and 4-5 TCA tree until now
  2. Steffen Ritter commented on patch set 2 08/28/11, 15:51

    No score
  3. Jigal van Hemert commented on patch set 2 V 0 08/28/11, 15:51

    by team member; Looks good to me, approved As Steffen said, without the submodule pointers and no other changes it can be merged.
  4. Marco Huber uploaded patch set 2 08/28/11, 15:51

  5. Lars Trebing commented on patch set 2 08/28/11, 15:51

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 08/28/11, 15:51

  7. Mr. Jenkins commented on patch set 2 08/28/11, 15:51

  8. Jigal van Hemert merged patch set 2 08/28/11, 15:51