34023[TASK] Change flashmessages.js for new FlashMessage styling
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Frank Nägler +2
- Christian Kuhn +1
- Stefan Froemken +1
-
Verified V +2
- Wouter Wolters +2
- Frank Nägler +2
- Christian Kuhn +1
- Stefan Froemken +1
Issues 1
Files 1
Review log 14
-
Kai Richter uploaded patch set 1 11/12/14, 17:20
-
Frank Nägler commented on patch set 1 V -1 CR -1 11/12/14, 17:34
I am on it -
Frank Nägler uploaded patch set 2 11/12/14, 17:39
-
Frank Nägler commented on patch set 2 V +1 CR +1 11/12/14, 18:03
works great, testable with browser console: TYPO3.Flashmessage.display(TYPO3.Severity.notice, 'test', 'test'); TYPO3.Flashmessage.display(TYPO3.Severity.information, 'test', 'test'); TYPO3.Flashmessage.display(TYPO3.Severity.ok, 'test', 'test'); TYPO3.Flashmessage.display(TYPO3.Severity.warning, 'test', 'test'); TYPO3.Flashmessage.display(TYPO3.Severity.error, 'test', 'test'); TYPO3.Flashmessage.display(0, 'test', 'test'); TYPO3.Flashmessage.display(1, 'test', 'test'); TYPO3.Flashmessage.display(2, 'test', 'test'); TYPO3.Flashmessage.display(3, 'test', 'test'); TYPO3.Flashmessage.display(4, 'test', 'test'); -
Christian Kuhn voted on patch set 2 CR +1 V +1 11/12/14, 18:16
-
Christian Kuhn commented on patch set 2 11/12/14, 18:17
Special thanks for the js commands! -
Wouter Wolters commented on patch set 2 CR -1 11/12/14, 18:28
Will push an updateflashmessages.js:46Use tabs please.. -
Wouter Wolters uploaded patch set 3 11/12/14, 18:33
-
Frank Nägler voted on patch set 3 V +2 CR +2 11/12/14, 18:40
-
Wouter Wolters commented on patch set 3 V +2 CR +2 11/12/14, 18:42
This fix also catches wrong usage of the flashmessage API. People calling the API with first param string instead of int. TYPO3.Flashmessage.display('information', 'test', 'test'); TYPO3.Flashmessage.display('error', 'test', 'test'); TYPO3.Flashmessage.display('info', 'test', 'test'); TYPO3.Flashmessage.display('danger', 'test', 'test');flashmessages.js:42this 'ok' is wrong here, that should be success. -
Wouter Wolters commented on patch set 3 11/12/14, 18:45
My inline comment is about what has gone wrong in the first fix for the new styling classes. -
Stefan Froemken voted on patch set 3 CR +1 V +1 11/12/14, 18:50
-
Christian Kuhn voted on patch set 3 CR +1 V +1 11/12/14, 19:21
-
Frank Nägler merged patch set 3 11/12/14, 19:21