Review main Merged

34052[BUGFIX] Drag & drop broken for inline records

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 11/13/14, 15:26

Commit message

Fix a problem with the latest FF version that moving
of IRRE records (reordering, via the drag/sortable icon
on the right) does not work.

Review

  • Code review CR +2
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Andreas Kienast +1

Issues 1

Files 1

Review log 11

  1. Wouter Wolters uploaded patch set 1 11/13/14, 10:48

  2. Markus Klein commented on patch set 1 11/13/14, 11:19

    Did you check why this is broken? Has there been a JS change?
  3. Wouter Wolters commented on patch set 1 11/13/14, 11:43

    Couldn't find a cause the js is the same as when it was implemented.. maybe the HTML structure changes caused this but Benni seems to not have this problem..
  4. Benni Mack commented on patch set 1 11/13/14, 14:32

    Fine on Chrome/Mac
  5. Wouter Wolters commented on patch set 1 11/13/14, 14:37

    Broken on FF, working on Chrome without this change.
  6. Benni Mack updated the commit message in patch set 2 11/13/14, 15:04

  7. Benni Mack voted on patch set 2 CR +1 V +1 11/13/14, 15:04

  8. Andreas Kienast commented on patch set 2 CR +1 V +1 11/13/14, 15:12

    Tested with Firefox 33.0
  9. Benni Mack voted on patch set 2 CR +2 V +2 11/13/14, 15:17

  10. Benni Mack merged patch set 2 11/13/14, 15:17

  11. Christian Bülter commented on patch set 1 11/13/14, 15:26

    Tested on Firefox/Ubuntu, works for me.