Review main Merged

34062[BUGFIX] TypoScript userFunc condition does not work with static methods

Oliver Hader CR +2 V +2 Easy +21 −1 updated 11/13/14, 15:26

Commit message

TypoScript allows to utilize functions (user-functions) to
integrate custom condition processing. However, this currently
only works with function defined in the global namespace - it
does not work with static methods.

Thus, something like this snipped won't work:
[userFunc = ConditionMatcherUserFunctions::isTrue(1)]

The solution is simple, replace function_exists() with a more
generic is_callable() check.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Files 3

Review log 5

  1. Oliver Hader uploaded patch set 1 11/13/14, 12:58

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 11/13/14, 13:25

  3. Markus Klein voted on patch set 1 CR +2 V +2 11/13/14, 15:26

  4. Markus Klein merged patch set 1 11/13/14, 15:26

  5. Markus Klein commented on patch set 2 11/13/14, 15:26

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit a2631f59972f062d65ecd928ec9de55b3bcea6f0