Review main Merged

34063[BUGFIX] Fix bug in HMENU special prev

Markus Klein CR -1 V +2 Easy +1 −1 updated 11/14/14, 10:34

Commit message

This patch fixes a regression of patch #61721.
The array before this patch had numeric indexes and thus the first
one was not recognized in the prev menu.

Review

  • Code review CR -1
    • Markus Klein +2
    • Nicole Hummel +2
    • Frederic Gaus -1
    • Mathias Schreiber +1
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2

Issues 2

Files 1

Review log 7

  1. Markus Klein commented on patch set 1 CR +2 V +2 11/13/14, 14:09

    FYI 6
  2. Mathias Schreiber voted on patch set 1 CR +1 11/13/14, 14:12

  3. Nicole Hummel voted on patch set 1 CR +2 11/13/14, 14:16

  4. Wouter Wolters voted on patch set 1 CR +1 11/13/14, 14:25

  5. Frederic Gaus commented on patch set 1 CR -1 11/13/14, 19:37

    I would suggest to revert #61721 for master. The solution with the closure is nicer imho
  6. Markus Klein commented on patch set 1 11/13/14, 20:22

    For simplicity I prefer to keep master and 6.2 in sync here
  7. Benni Mack merged patch set 1 11/14/14, 10:34