Review TYPO3_6-2 Merged

34087[BUGFIX] TypoScript userFunc condition does not work with static methods

Markus Klein CR +2 V +2 Easy +23 −3 updated 11/13/14, 15:27

Commit message

TypoScript allows to utilize functions (user-functions) to
integrate custom condition processing. However, this currently
only works with function defined in the global namespace - it
does not work with static methods.

Thus, something like this snipped won't work:
[userFunc = ConditionMatcherUserFunctions::isTrue(1)]

The solution is simple, replace function_exists() with a more
generic is_callable() check.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Files 3

Review log 2

  1. Markus Klein voted on patch set 1 CR +2 V +2 11/13/14, 15:27

  2. Markus Klein merged patch set 1 11/13/14, 15:27