Review main Merged

34089[FOLLOWUP] Convert remaining occurences of makeInstance

Xavier Perseguers CR +2 V +2 Hard +135 −141 updated 11/13/14, 23:31

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Alexander Opitz +1
    • Markus Klein +1
    • Xavier Perseguers +1
  • Verified V +2
    • Wouter Wolters +2
    • Alexander Opitz +1
    • Markus Klein +1
    • Xavier Perseguers +1

Issues 1

Files 46

Show 26 more files

Review log 9

  1. Xavier Perseguers uploaded patch set 1 11/13/14, 15:47

  2. Markus Klein commented on patch set 1 CR -1 11/13/14, 16:00

    We still miss 19 occurrences. will push a new set
  3. Markus Klein uploaded patch set 2 11/13/14, 16:10

  4. Markus Klein voted on patch set 2 CR +1 V +1 11/13/14, 16:10

  5. Alexander Opitz commented on patch set 2 V +1 CR +1 11/13/14, 16:14

    Fine, but maybe some more like to review.
  6. Xavier Perseguers commented on patch set 2 CR +1 V +1 11/13/14, 17:58

    ActionService.php:432

    don't really like this shortcut tbh
  7. Markus Klein commented on patch set 2 11/13/14, 18:07

    ActionService.php:432 Reply

    Well, the method it self is not nice. Either it should create a DH instance and return it, or create one and store it internally, but not both.
  8. Wouter Wolters voted on patch set 2 V +2 CR +2 11/13/14, 23:31

  9. Wouter Wolters merged patch set 2 11/13/14, 23:31