34089[FOLLOWUP] Convert remaining occurences of makeInstance
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Alexander Opitz +1
- Markus Klein +1
- Xavier Perseguers +1
-
Verified V +2
- Wouter Wolters +2
- Alexander Opitz +1
- Markus Klein +1
- Xavier Perseguers +1
Issues 1
Files 46
- typo3/sysext/aboutmodules/Classes/Controller/ModulesController.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+1 −1
- typo3/sysext/backend/Classes/Form/FormEngine.php+2 −3
- typo3/sysext/backend/Classes/InterfaceState/ExtDirect/DataProvider.php+1 −1
- typo3/sysext/backend/Classes/View/BackendLayout/BackendLayout.php+1 −1
- typo3/sysext/backend/Classes/View/BackendLayout/DataProviderCollection.php+1 −1
- typo3/sysext/backend/Classes/View/BackendLayoutView.php+2 −4
- typo3/sysext/backend/Classes/View/PageLayoutView.php+3 −5
- typo3/sysext/core/Classes/Category/Collection/CategoryCollection.php+1 −1
- typo3/sysext/core/Classes/Collection/StaticRecordCollection.php+1 −1
- typo3/sysext/core/Classes/Error/ErrorHandler.php+1 −1
- typo3/sysext/core/Classes/Error/ProductionExceptionHandler.php+1 −1
- typo3/sysext/core/Classes/FormProtection/BackendFormProtection.php+7 −5
- typo3/sysext/core/Classes/Messaging/FlashMessageService.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+1 −1
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+5 −5
- typo3/sysext/core/Classes/Utility/MailUtility.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Breaking-61828-RemoveIsDisplayCondition.rst+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Framework/ActionService.php2+3 −7
- typo3/sysext/core/Tests/Functional/DataHandling/Framework/DataSet.php+1 −1
Show 26 more files
- typo3/sysext/core/Tests/Functional/DataHandling/AbstractDataHandlerActionTestCase.php+1 −1
- typo3/sysext/core/Tests/Functional/Framework/Frontend/Hook/BackendUserHandler.php+1 −1
- typo3/sysext/core/Tests/Functional/Framework/Frontend/Collector.php+1 −1
- typo3/sysext/core/Tests/Functional/Framework/Frontend/Renderer.php+1 −1
- typo3/sysext/documentation/Classes/Controller/DocumentController.php+41 −40
- typo3/sysext/extbase/Classes/Mvc/Controller/AbstractController.php+1 −1
- typo3/sysext/frontend/Classes/Category/Collection/CategoryCollection.php+1 −1
- typo3/sysext/frontend/Classes/FrontendRequestHandler.php+1 −1
- typo3/sysext/func/Classes/Controller/PageFunctionsController.php+1 −1
- typo3/sysext/impexp/Classes/Task/ImportExportTask.php+1 −1
- typo3/sysext/install/Classes/Report/EnvironmentStatusReport.php+1 −1
- typo3/sysext/install/Classes/Updates/AbstractUpdate.php+1 −1
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+7 −6
- typo3/sysext/lowlevel/Classes/View/ConfigurationView.php+5 −4
- typo3/sysext/openid/Classes/Wizard.php+15 −17
- typo3/sysext/openid/wizard/index.php+1 −1
- typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −1
- typo3/sysext/reports/Classes/Report/Status/FalStatus.php+1 −1
- typo3/sysext/reports/Classes/Report/Status/Typo3Status.php+2 −2
- typo3/sysext/sys_action/Classes/ActionTask.php+1 −1
- typo3/sysext/version/Classes/DataHandler/CommandMap.php+5 −3
- typo3/sysext/version/Classes/Hook/DataHandlerHook.php+1 −1
- typo3/sysext/version/Classes/Hook/PreviewHook.php+1 −1
- typo3/sysext/workspaces/Classes/Service/Dependency/CollectionService.php+5 −7
- typo3/show_item.php+1 −1
Review log 9
-
Xavier Perseguers uploaded patch set 1 11/13/14, 15:47
-
Markus Klein commented on patch set 1 CR -1 11/13/14, 16:00
We still miss 19 occurrences. will push a new set -
Markus Klein uploaded patch set 2 11/13/14, 16:10
-
Markus Klein voted on patch set 2 CR +1 V +1 11/13/14, 16:10
-
Alexander Opitz commented on patch set 2 V +1 CR +1 11/13/14, 16:14
Fine, but maybe some more like to review. -
Xavier Perseguers commented on patch set 2 CR +1 V +1 11/13/14, 17:58
ActionService.php:432don't really like this shortcut tbh -
Markus Klein commented on patch set 2 11/13/14, 18:07
ActionService.php:432ReplyWell, the method it self is not nice. Either it should create a DH instance and return it, or create one and store it internally, but not both. -
Wouter Wolters voted on patch set 2 V +2 CR +2 11/13/14, 23:31
-
Wouter Wolters merged patch set 2 11/13/14, 23:31