34097[TASK] Reduze RTE configuration to a minimum
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 5
- typo3/sysext/rtehtmlarea/Configuration/PageTS/Typical/pageTSConfig.txt3+328 −116
- typo3/sysext/rtehtmlarea/Resources/Public/Css/ContentCss/Default.css+5 −25
- typo3/sysext/rtehtmlarea/Resources/Public/Css/Bootstrap.min.cssnew+5 −0
- typo3/sysext/rtehtmlarea/Resources/Public/Css/Rte.css1new+85 −0
- typo3/sysext/rtehtmlarea/ext_conf_template.txt+1 −1
Review log 17
-
Stefan Froemken uploaded patch set 1 11/13/14, 16:52
-
Stefan Froemken uploaded patch set 2 11/14/14, 10:07
-
Stefan Froemken uploaded patch set 3 11/14/14, 10:27
-
Stanislas Rolland commented on patch set 3 11/17/14, 23:32
This is merging the configuration of the RTE and the configuration of the RTE transformations. Is this a good idea? There is currently a distinct file for RTE transformation configuration in Configuration/PageTS/Proc/pageTSConfig.txt -
Stanislas Rolland commented on patch set 3 11/17/14, 23:54
pageTSConfig.txt:84Such multi-line lists in Page TS, when json-encoded for JavaScript, give undesired results: in this case b, p and table will be delivered as \tb, \tp and \ttablepageTSConfig.txt:113buttons. is repeated here. This won't work.pageTSConfig.txt:146big and small are not supported by the browsers execCommand. Therefore, these two buttons will not appear unless the additionnal inline elements are enabled in the extension configuration. -
Stanislas Rolland commented on patch set 3 11/18/14, 01:14
The intent of the Advanced configuration was to be minimal. -
Markus Klein commented on patch set 3 CR -1 11/18/14, 09:38
Phew.... Actually I'm against bundling RTE with bootstrap. There's still pages out there that will not use bootstrap at all. For them this is really breaking.Should be 'Reduce', right? -
Stanislas Rolland commented on patch set 3 11/18/14, 12:58
Documenting all the breaking changes included in this change would help to understand what it is trying to achieve. Adding more stringent rules to the RTE transformations is actually making the configuration more complex. A minimum configuration would mean no transformation at all. -
Mathias Schreiber wrote 12/17/14, 14:33
Topic set to EXT: rtehtmlarea -
Benni Mack commented on patch set 3 02/01/15, 15:22
Stefan, are you up for taking the comments of Stan and Markus into account? otherwise I suggest to abandon the issue in the near future as there is no activity. -
Felix Kopp commented on patch set 3 02/01/15, 22:19
The commit messages is confusing since the configuration size is doubled. Please give me insights on the Bootstrap approach. Thanks!!Rte.css:1What for? Normalize.css should be just fine! This blows the whole CSS up quite a lot. Please give insights on the desired results -
Benni Mack commented on patch set 3 02/25/15, 23:21
ping to Stefan F., otherwise I will abandon this one in a few days. -
Stefan Froemken commented on patch set 3 02/26/15, 08:06
Hello. I have just contacted Stanislas. The origin idea comes from Mattes. Maybe he has also some ideas what should stay and what we should throw away. -
Felix Kopp commented on patch set 3 03/09/15, 10:22
Anything new? -
Stefan Froemken commented on patch set 3 03/09/15, 21:07
I get no answer. Same progrem as in Core list. Please tell me WHAT buttons you want configured and I will modify this patch. Let us discuss whereever you want. Send me an email. Contact me at slack. Should we allow tables in RTE? What about images? Do you want some new defaults for styles, alignments, fonts? Please tell me. -
Benni Mack commented on patch set 3 CR -1 08/07/15, 13:41
As discussed I think we need to simplify the transformation process and not the RTE configuration. That's why we should abandon this patch. -
Wouter Wolters abandoned the change 11/14/15, 11:16
For the mentioned reasons and no activity for a long time I abandon this change request.