Review main Merged

34108[BUGFIX] Correctly parse timestamps in format.date VH

Markus Klein CR +2 V +2 Easy +26 −15 updated 11/18/14, 22:16

Commit message

If the timestamp is retrieved from child nodes, the date format
ViewHelper has to ensure the timestamp is properly recognized.
As child nodes are always returning a string, the former check with
is_integer() would never return TRUE.
Therefore adapt this check to use the MathUtility method as this
guarantees a proper check.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Froemken +1
  • Verified V +2
    • Wouter Wolters +2
    • Stefan Froemken +1

Issues 1

Files 2

Review log 7

  1. Markus Klein uploaded patch set 1 11/13/14, 19:18

  2. Stefan Froemken voted on patch set 1 CR +1 V +1 11/14/14, 11:33

  3. Stefan Froemken updated the commit message in patch set 2 11/14/14, 11:34

  4. Stefan Froemken voted on patch set 2 CR +1 V +1 11/14/14, 11:34

  5. Wouter Wolters voted on patch set 2 V +2 CR +2 11/18/14, 22:16

  6. Wouter Wolters merged patch set 2 11/18/14, 22:16

  7. Wouter Wolters commented on patch set 3 11/18/14, 22:16

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 0cd4ef6e89cd423b88320dea6626b388ce7e1ec5