Review main Merged

34163[BUGFIX] Add namespace argument for inline settings array

Frank Nägler CR +2 V +2 Easy +3 −2 updated 11/14/14, 13:48

Commit message

Make it possible to set a namespace for inline settings array

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Froemken +1
  • Verified V +2
    • Christian Kuhn +2
    • Stefan Froemken +1

Issues 1

Files 1

Review log 11

  1. Frank Nägler uploaded patch set 1 11/14/14, 12:18

  2. Frans Saris commented on patch set 1 CR +1 11/14/14, 12:21

    Where is this used? So I can test and understand the use-case :)
  3. Stefan Froemken commented on patch set 1 11/14/14, 12:24

    The core does not make use of this ViewHelper. You have to create your own little backend module for testing.
  4. Frank Nägler commented on patch set 1 11/14/14, 12:26

    used in core EXT:belog use custom date range. I need the namespace for the new datepicker (another patch, not ready yet)
  5. Frank Nägler uploaded patch set 2 11/14/14, 12:29

  6. Frank Nägler commented on patch set 2 11/14/14, 12:29

    changed commit message, also useful in 6.2
  7. Stefan Froemken commented on patch set 2 CR +1 V +1 11/14/14, 12:35

    Sorry. I had activated file mask *.php in PhpStorm while searching. Works good.
  8. Christian Kuhn voted on patch set 2 CR +2 V +2 11/14/14, 12:47

  9. Christian Kuhn merged patch set 2 11/14/14, 12:48

  10. Markus Klein commented on patch set 3 11/14/14, 13:46

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 9a35d8b58d9b1f9e7e8171c4f065f6a88bc7f4b2
  11. Markus Klein commented on patch set 3 11/14/14, 13:48

    typo here.