Review main Merged

34198[BUGFIX] Hide empty tabs in DynTabMenu

Benni Mack CR +2 V +2 Easy +1 −1 updated 11/15/14, 12:09

Commit message

Due to a previous tab patch, empty
tabs in e.g. FormEngine are always
shown but disabled (= unstyled).

The patch sets the default tab
behaviour to hide tabs that are
empty.

Review

  • Code review CR +2
    • Felix Kopp +2
    • Oliver Hader +2
  • Verified V +2
    • Felix Kopp +2
    • Oliver Hader +2

Issues 1

Files 1

Review log 8

  1. Benni Mack uploaded patch set 1 11/15/14, 10:09

  2. Markus Klein commented on patch set 1 11/15/14, 10:15

    Please add testing instructions to forge. where to find empty tabs?
  3. Benni Mack commented on patch set 1 11/15/14, 11:06

  4. Felix Kopp commented on patch set 1 CR +2 V +2 11/15/14, 11:58

    +1 for stronger defaults
  5. Felix Kopp commented on patch set 1 11/15/14, 11:58

    Waiting for markus
  6. Oliver Hader voted on patch set 1 CR +2 V +2 11/15/14, 12:09

  7. Oliver Hader commented on patch set 1 11/15/14, 12:09

    Tested with styleguide extension
  8. Oliver Hader merged patch set 1 11/15/14, 12:09