Review main Merged

34209[CLEANUP] Deprecate unused/non-unified DocumentTemplate code

Benni Mack CR +2 V +2 Normal +64 −31 updated 11/15/14, 23:15

Commit message

Several functions within DocumentTemplate are
not encouraged to be used anymore.

The hard-coded background image setting
via $TBE_STYLES['background'] is removed
and its usage is deprecated.

Additionally, the font-wrapping methods
are deprecated. All places in the core using
these methods are removed. The according
CSS was removed from the core (can still
be used via 3rd party extensions).

collapseableSection, which was used solely
by the reports module for ages in a buggy
way, is also deprecated in favor of Bootstrap
collapseables and localstorage.

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • Christian Kuhn +1

Issues 1

Files 9

Review log 9

  1. Benni Mack uploaded patch set 1 11/15/14, 14:26

  2. Georg Ringer uploaded patch set 2 11/15/14, 20:59

  3. Georg Ringer voted on patch set 2 V +1 CR +1 11/15/14, 21:00

  4. Christian Kuhn voted on patch set 2 CR -1 11/15/14, 22:56

  5. Christian Kuhn uploaded patch set 3 11/15/14, 22:59

  6. Christian Kuhn voted on patch set 3 CR +1 V +1 11/15/14, 23:01

  7. Georg Ringer voted on patch set 3 CR +1 V +1 11/15/14, 23:15

  8. Benni Mack voted on patch set 3 CR +2 V +2 11/15/14, 23:15

  9. Benni Mack merged patch set 3 11/15/14, 23:15