Review main Merged

34215[TASK] Update DataTables version

Kai Richter CR +2 V +2 Hard +158 −158 updated 11/16/14, 11:26

Commit message

This patch replaces the DataTables version in contrib. It updates the
library from version 1.9.4 to 1.10.2. Currently just the extension
manager, language and documentation module are using it.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 5

Review log 16

  1. Kai Richter uploaded patch set 1 11/15/14, 17:50

  2. Kai Richter uploaded patch set 2 11/15/14, 17:57

  3. Felix Kopp commented on patch set 2 11/15/14, 18:18

    We could keep the old file in case it is included by it's full file patch. Comments welcome :)
  4. Kai Richter commented on patch set 2 11/15/14, 19:26

    @Felix: Yes we can do that. But for feature releases we can think about renaming the file to jquery.dataTables.min.js to allow an update of the library without editing all occurrences.
  5. Kai Richter uploaded patch set 3 11/15/14, 19:28

  6. Georg Ringer commented on patch set 3 CR +1 V +1 11/15/14, 21:27

    IMO we should add a deprecation comment in the previous file so that we don't miss it? + rst?
  7. Felix Kopp commented on patch set 3 11/16/14, 09:29

    Either we need a RST file or keep the previous .js file next to 1.10
  8. Christian Kuhn commented on patch set 3 11/16/14, 10:25

    Quoting "README.txt" in this folder: Please *DO NOT* reference/use the jQuery-libraries in this folder from your own extensions. They are used throughout the TYPO3 CMS core but may be renamed or removed without further notice in later TYPO3-versions. We plan to provide and promote a central API for using jQuery (also in various versions) in one of the next releases.
  9. Christian Kuhn uploaded patch set 4 11/16/14, 10:36

  10. Christian Kuhn commented on patch set 4 11/16/14, 10:37

    Pushed version 2 from Kai again that removes the old lib. will test now.
  11. Christian Kuhn voted on patch set 4 CR +1 V +1 11/16/14, 11:07

  12. Christian Kuhn commented on patch set 4 11/16/14, 11:08

    lets get it in.
  13. Anja Leichsenring voted on patch set 4 CR +2 V +2 11/16/14, 11:18

  14. Anja Leichsenring merged patch set 4 11/16/14, 11:18

  15. Benni Mack commented on patch set 5 11/16/14, 11:25

    guys, you know that stuff like this is uncool? No note that you raise versions and delete contrib files? this is a different story than moving our files. I recommend the following, and would like for a followup: please move "jquery.dataTables-1.10.2.min.js" to "jquery.dataTables.min.js". This way we can update the version (even minor fixes) without notifying everybody that they need to reference a new file. In long run, I will provide a README file in contrib pointing to the things we ensure that they are there for a couple of versions, the rest is internal API.
  16. Benni Mack commented on patch set 5 11/16/14, 11:26

    Ah, ok. I just checked myself (and saw lolli's quote). Renaming still OK? I do this the same way with other libraries as well (except jquery).