34215[TASK] Update DataTables version
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2
- Anja Leichsenring +2
- Christian Kuhn +1
Issues 1
Files 5
- typo3/contrib/jquery/jquery.dataTables-1.9.4.min.jsdeleted+0 −155
- typo3/contrib/jquery/jquery.dataTables-1.10.2.min.jsnew+155 −0
- typo3/sysext/documentation/Resources/Private/Layouts/Default.html+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Layouts/Main.html+1 −1
- typo3/sysext/lang/Resources/Private/Layouts/Default.html+1 −1
Review log 16
-
Kai Richter uploaded patch set 1 11/15/14, 17:50
-
Kai Richter uploaded patch set 2 11/15/14, 17:57
-
Felix Kopp commented on patch set 2 11/15/14, 18:18
We could keep the old file in case it is included by it's full file patch. Comments welcome :) -
Kai Richter commented on patch set 2 11/15/14, 19:26
@Felix: Yes we can do that. But for feature releases we can think about renaming the file to jquery.dataTables.min.js to allow an update of the library without editing all occurrences. -
Kai Richter uploaded patch set 3 11/15/14, 19:28
-
Georg Ringer commented on patch set 3 CR +1 V +1 11/15/14, 21:27
IMO we should add a deprecation comment in the previous file so that we don't miss it? + rst? -
Felix Kopp commented on patch set 3 11/16/14, 09:29
Either we need a RST file or keep the previous .js file next to 1.10 -
Christian Kuhn commented on patch set 3 11/16/14, 10:25
Quoting "README.txt" in this folder: Please *DO NOT* reference/use the jQuery-libraries in this folder from your own extensions. They are used throughout the TYPO3 CMS core but may be renamed or removed without further notice in later TYPO3-versions. We plan to provide and promote a central API for using jQuery (also in various versions) in one of the next releases. -
Christian Kuhn uploaded patch set 4 11/16/14, 10:36
-
Christian Kuhn commented on patch set 4 11/16/14, 10:37
Pushed version 2 from Kai again that removes the old lib. will test now. -
Christian Kuhn voted on patch set 4 CR +1 V +1 11/16/14, 11:07
-
Christian Kuhn commented on patch set 4 11/16/14, 11:08
lets get it in. -
Anja Leichsenring voted on patch set 4 CR +2 V +2 11/16/14, 11:18
-
Anja Leichsenring merged patch set 4 11/16/14, 11:18
-
Benni Mack commented on patch set 5 11/16/14, 11:25
guys, you know that stuff like this is uncool? No note that you raise versions and delete contrib files? this is a different story than moving our files. I recommend the following, and would like for a followup: please move "jquery.dataTables-1.10.2.min.js" to "jquery.dataTables.min.js". This way we can update the version (even minor fixes) without notifying everybody that they need to reference a new file. In long run, I will provide a README file in contrib pointing to the things we ensure that they are there for a couple of versions, the rest is internal API. -
Benni Mack commented on patch set 5 11/16/14, 11:26
Ah, ok. I just checked myself (and saw lolli's quote). Renaming still OK? I do this the same way with other libraries as well (except jquery).