Review main Merged

34243[TASK] Remove dependency on EXT:cshmanual

Benni Mack CR +2 V +2 Easy +13 −5 updated 11/23/14, 21:00

Commit message

Adding some preliminary isLoaded functions
in order to allow to uninstall EXT:cshmanual
and thus, be able to hide the full toolbar item.

The long-term solution should still be to
implement a new help concept and drop
cshmanual, the csh icon and TCA_DESCR

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1

Issues 1

Files 4

Review log 8

  1. Benni Mack uploaded patch set 1 11/16/14, 11:33

  2. Benni Mack updated the commit message in patch set 2 11/22/14, 10:57

  3. Wouter Wolters commented on patch set 2 V +1 CR -1 11/22/14, 11:31

    missing releases line and forge ticket
  4. Benni Mack updated the commit message in patch set 3 11/22/14, 23:59

  5. Wouter Wolters voted on patch set 3 V +1 CR +1 11/23/14, 13:08

  6. Benni Mack commented on patch set 3 11/23/14, 13:51

    how to test: apply the patch, clear the system caches, now you're able to uninstall cshmanual via the extension manager. Reload the backend and see if anything breaks.
  7. Georg Ringer voted on patch set 3 CR +2 V +2 11/23/14, 21:00

  8. Georg Ringer merged patch set 3 11/23/14, 21:00