Review main Merged

34244[TASK] Migrate leftover userfunc for tt_content to hook class

Benni Mack CR +2 V +2 Easy +37 −13 updated 11/23/14, 22:12

Commit message

One method still initialized on every uncached call
is user_sortPluginList() which is used in TCA tt_content
to sort all plugins by name (trivial, right?).

The patch moves the code in the right direction.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Helmut Hummel +2
    • Mathias Schreiber +1
  • Verified V +2
    • Wouter Wolters +2
    • Mathias Schreiber +1

Issues 1

Files 3

Review log 7

  1. Benni Mack uploaded patch set 1 11/16/14, 11:56

  2. Frans Saris commented on patch set 1 11/16/14, 12:05

    Why did you create a hook class and not a UserFunc class?
  3. Benni Mack commented on patch set 1 11/16/14, 17:30

    I don't really much about the naming actually, but I don't know the naming scheme that could fit. UserFunc Class is IMHO a contradiction in itself ;) But again, I don't know where it should fit best. Lolli?
  4. Helmut Hummel commented on patch set 1 CR +2 11/20/14, 21:03

    I'm fine with the name
  5. Mathias Schreiber voted on patch set 1 CR +1 V +1 11/21/14, 08:28

  6. Wouter Wolters voted on patch set 1 V +2 CR +2 11/23/14, 22:12

  7. Wouter Wolters merged patch set 1 11/23/14, 22:12