34251[TASK] Update icons for move-down/up
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Felix Kopp +2
-
Verified V +2
- Georg Ringer +2
- Felix Kopp +2
Issues 1
Files 1
Review log 11
-
Georg Ringer uploaded patch set 1 11/16/14, 20:33
-
Frank Nägler commented on patch set 1 V +1 CR +1 11/16/14, 20:41
looks good, but the delete icon is much bigger (bolder) then the arrows, maybe this could be changed so that all icons in harmony. Would like to see a feedback of Felix for this patch. -
Anja Leichsenring commented on patch set 1 CR -1 11/16/14, 21:02
Please wait for verification from the Design Team. -
Felix Kopp commented on patch set 1 11/17/14, 14:14
Thanks for waiting. I feel strongly that left/right and top/down and up/down should be similar. Either we use angle / chevron or arrow. Since there is no adequate top/bottom *arrow we need to use angle or chevron. Chevron top could be the chevron-circle - … but *angle is currently probably the best solution. Please just add the angle for left/right navigation also and fire!!IconStyleModifier.php:56Angle then as wellIconStyleModifier.php:57angle here also -
Felix Kopp commented on patch set 1 11/17/14, 14:15
Yes, although the Angle is pretty light and condensed. -
Georg Ringer uploaded patch set 2 11/18/14, 06:54
-
Felix Kopp uploaded patch set 3 11/18/14, 15:24
-
Felix Kopp commented on patch set 3 CR +1 V +1 11/18/14, 15:25
Added "normal" icon case without FormEngine t3-btn also. Thanks, Schorsch!! -
Georg Ringer voted on patch set 3 CR +2 V +2 11/18/14, 15:48
-
Felix Kopp voted on patch set 3 CR +2 V +2 11/18/14, 16:15
-
Felix Kopp merged patch set 3 11/18/14, 16:15