Review main Merged

34276[TASK] Style progress bar with Twitter Bootstrap in ext:scheduler

Wouter Wolters CR +2 V +2 Normal +6 −48 updated 11/19/14, 19:01

Commit message

Review

  • Code review CR +2
    • Felix Kopp +2
    • Kai Richter +1
  • Verified V +2
    • Felix Kopp +2
    • Kai Richter +1

Issues 1

Files 3

Review log 12

  1. Wouter Wolters uploaded patch set 1 11/17/14, 17:45

  2. Wouter Wolters wrote 11/17/14, 17:50

    Topic set to twbs
  3. Kai Richter voted on patch set 1 V +1 CR +1 11/17/14, 18:53

  4. Felix Kopp commented on patch set 1 CR -1 11/17/14, 22:42

    The style of Scheduler progress bar should be enabled core-wide from within EXT: t3skin. Let us move the style definition into bootstrap and only use .progress, get the styling from t3skin and do not send new styling in scheduler. I hope move extensions might use .progress in the long run
  5. Wouter Wolters commented on patch set 1 11/17/14, 22:44

    Uh I don't get your point here Felix. I'm removing the styles to have it come from t3skin.css ????
  6. Kai Richter commented on patch set 1 11/18/14, 06:55

    Maybe we can also add a ViewHelper for progress bars to standardize their usage?
  7. Andreas Kienast commented on patch set 1 11/18/14, 11:22

    How can I test this patch? I have two task groups, each containing one task but I don't see a progressbar.
  8. Wouter Wolters commented on patch set 1 11/18/14, 11:46

    A progressbar is shown when you implement the ProgessProviderInterface in the task and implement the function getProgress that returns a float. Then the progress bar is shown in the overview. I did this by editing the example SleepTask.
  9. Andreas Kienast commented on patch set 1 11/18/14, 12:02

    Some ideas:

    SchedulerModuleController.php:427

    The prefixed text might should be removed. If the progress is e.g. 13%, only "Progres" is visible here.

    SchedulerModuleController.php:429

    If $progress is < 100, the class "active" might be added to visualize a running task. Also, if completed, add the class "progress-bar-[danger|success]", depending on success status?
  10. Felix Kopp commented on patch set 1 CR +1 V +1 11/19/14, 18:54

    SchedulerModuleController.php:427 Reply

    Yes, I also woute for XX% only - also min-width for progress might make sense. But XX% is really good.
  11. Felix Kopp voted on patch set 1 CR +2 V +2 11/19/14, 19:01

  12. Felix Kopp merged patch set 1 11/19/14, 19:01