Review main Abandoned

34289[TASK] Use font-icons in module groups

Frank Nägler CR 0 V 0 Easy +37 −3 updated 11/18/14, 14:37

Commit message

Replace the images in module groups with font icons.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 11

  1. Frank Nägler uploaded patch set 1 11/17/14, 23:02

  2. Frank Nägler uploaded patch set 2 11/17/14, 23:19

  3. Frank Nägler uploaded patch set 3 11/17/14, 23:50

  4. Frank Nägler uploaded patch set 4 11/17/14, 23:57

  5. Frank Nägler commented on patch set 4 V -1 CR -1 11/18/14, 08:35

    blocked until Felix or the Design-Team approve this patch.
  6. Christian Kuhn commented on patch set 4 CR -1 11/18/14, 08:43

    these are not the icons Dirk worked on during the sprint ... @Frank: Please coordinate with Felix.
  7. Frank Nägler commented on patch set 4 11/18/14, 08:48

    @Lolli, see my comment above ;)
  8. Felix Kopp commented on patch set 4 CR -2 11/18/14, 12:34

    Jo! Please don't use these icons here. Patchset https://review.typo3.org/#/c/32876/ will send new icons. The App icons must be png icons still since all extensions send their own icons. Font awesome will not full-fill all use cases for icons here. Please see the description and guide in https://forge.typo3.org/issues/62158 also the PSD and icon archive attached :)
  9. Felix Kopp commented on patch set 4 11/18/14, 12:45

    (Discussed the other approach with Frank on Slack)
  10. Frank Nägler commented on patch set 4 11/18/14, 14:37

    the new icon system is great, I love it. Will abandon this patch.
  11. Frank Nägler abandoned the change 11/18/14, 14:37