Review main Merged Breaking

34319[!!!][BUGFIX] Prefer root templates for template evaluation

Markus Klein CR +2 V +2 Easy +28 −1 updated 11/20/14, 23:10

Commit message

The Core always tries to use the first template according to their
sorting on a page. This totally ignores the root-flag of a template.

Change the evaluation to give root templates precedence over
extension templates independent of the sorting.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Wouter Wolters +1

Issues 1

Files 2

Review log 9

  1. Markus Klein uploaded patch set 1 11/18/14, 20:07

  2. Benni Mack voted on patch set 1 CR +1 11/18/14, 20:23

  3. Wouter Wolters commented on patch set 1 CR +1 11/18/14, 22:08

    the evaluation to give ?
  4. Markus Klein updated the commit message in patch set 2 11/18/14, 23:45

  5. Mathias Schreiber commented on patch set 2 CR +1 V +1 11/19/14, 08:20

    works and makes total sense btw.
  6. Benni Mack voted on patch set 2 CR +2 11/20/14, 15:35

  7. Wouter Wolters commented on patch set 2 V +1 CR +1 11/20/14, 22:44

    Benni, please decide if you want this in before 7.0 release
  8. Christian Kuhn voted on patch set 2 CR +2 V +2 11/20/14, 23:09

  9. Christian Kuhn merged patch set 2 11/20/14, 23:10