Review TYPO3_6-2 Merged

34323[BUGFIX] Correctly parse timestamps in format.date VH

Wouter Wolters CR +2 V +2 Easy +26 −15 updated 11/19/14, 18:25

Commit message

If the timestamp is retrieved from child nodes, the date format
ViewHelper has to ensure the timestamp is properly recognized.
As child nodes are always returning a string, the former check with
is_integer() would never return TRUE.
Therefore adapt this check to use the MathUtility method as this
guarantees a proper check.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Issues 1

Files 2

Review log 2

  1. Wouter Wolters voted on patch set 1 V +2 CR +2 11/19/14, 18:25

  2. Wouter Wolters merged patch set 1 11/19/14, 18:25