34324[TASK] Add btn-group to ext:beuser
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Frank Nägler +1
-
Verified V +2
- Markus Klein +2
- Frank Nägler +1
Issues 1
Files 4
- typo3/sysext/beuser/Classes/ViewHelpers/RemoveUserViewHelper.php1+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/SwitchUserViewHelper.php1+1 −1
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/IndexListRow.html+22 −20
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/OnlineListRow.html+6 −4
Review log 11
-
Wouter Wolters uploaded patch set 1 11/18/14, 22:28
-
Markus Klein voted on patch set 1 CR +1 V +1 11/18/14, 23:32
-
Felix Kopp commented on patch set 1 CR +1 V +1 11/19/14, 00:17
Great, but we could also add the col-control to the btn-group column. I added an example to EXT: styleguide for documentation. -
Frans Saris commented on patch set 1 11/19/14, 07:50
RemoveUserViewHelper.php:38Imo we should define the used class in template and not hardcode it here in the viewhelperSwitchUserViewHelper.php:37Same here -
Wouter Wolters uploaded patch set 2 11/19/14, 08:03
-
Wouter Wolters commented on patch set 2 11/19/14, 08:04
@frans what do you want to achieve with that? The class is needed on the a-tag that is rendered by the ViewHelper. Nothing in the template for that. -
Frans Saris commented on patch set 2 11/19/14, 08:25
Separate markup/layout from functionality :) if in a later point in time we want to add/change classes only the template needs to be adjusted. Did have a look at the other custom ViewHelpers in core extensions, but imo we should use ViewHelpers also in these pleases the correct way. -
Mathias Schreiber commented on patch set 2 11/19/14, 15:12
Hey wouter, please check if we can join forces here https://review.typo3.org/#/c/34348/ -
Frank Nägler voted on patch set 2 V +1 CR +1 11/19/14, 19:03
-
Markus Klein voted on patch set 2 CR +2 V +2 11/19/14, 19:37
-
Markus Klein merged patch set 2 11/19/14, 19:37