Review main Merged

34348[TASK] Twitter Bootstrap EXT:beuser follow up

Mathias Schreiber CR +2 V +2 Hard +180 −152 updated 11/20/14, 08:18

Commit message

* Visual streamlining of EXT:beuser
* align buttons in button groups and fillup empty buttons.
* hide the "hide" button for current loggedin user

Review

  • Code review CR +2
    • Frank Nägler +2
    • Markus Klein +1
  • Verified V +2
    • Frank Nägler +2
    • Markus Klein +1

Issues 1

Files 11

Review log 22

  1. Mathias Schreiber uploaded patch set 1 11/19/14, 15:10

  2. Mathias Schreiber uploaded patch set 2 11/19/14, 16:23

  3. Mathias Schreiber uploaded patch set 3 11/19/14, 16:49

  4. Frank Nägler commented on patch set 3 CR -1 11/19/14, 18:09

    on it, will push a new set soon

    BackendUser.php:50

    ???
  5. Wouter Wolters commented on patch set 3 CR -1 11/19/14, 18:10

    This are 3 patches in one.. Please seperate them
  6. Mathias Schreiber commented on patch set 3 11/19/14, 18:27

    can you explain which 3 parts you mean? All I do is style the thing :)

    BackendUser.php:50 Reply

    can't extbase do this?
  7. Wouter Wolters commented on patch set 3 11/19/14, 18:33

    Ah hit the button to soon. 1. add button group 2. restyle the form 3. implement the check to be unable to disable yourself and this is IMO not a cleanup
  8. Frank Nägler uploaded patch set 4 11/19/14, 20:24

  9. Markus Klein commented on patch set 4 CR -1 11/19/14, 22:16

    BackendUser.php:127

    Check

    BackendUser.php:128

    bool

    BackendUser.php:131

    === maybe?

    BackendUser.php:131

    getter for the global please

    BackendUser.php:131

    no need for that. the expression already has a boolean result!

    IndexListRow.html:16

    translation gone?

    IndexListRow.html:22

    should be lowercased isCurr... maybe it works like this, but for consistency
  10. Andreas Kienast uploaded patch set 5 11/19/14, 22:18

  11. Andreas Kienast uploaded patch set 6 11/19/14, 22:21

  12. Markus Klein commented on patch set 6 CR -1 11/19/14, 22:27

    BackendUser.php:50

    @transient

    BackendUser.php:52

    The property is unused

    BackendUser.php:131

    isCurrentlyLoggedIn()

    BackendUser.php:132

    int cast for safety
  13. Markus Klein commented on patch set 6 11/19/14, 22:29

    IndexListRow.html:21

    tabs
  14. Markus Klein commented on patch set 6 V -1 11/19/14, 22:33

    IndexListRow.html:16

    translation missing

    IndexListRow.html:34

    invalid xml, use inline format instead
  15. Markus Klein uploaded patch set 7 11/19/14, 22:48

  16. Markus Klein uploaded patch set 8 11/19/14, 23:21

  17. Markus Klein uploaded patch set 9 11/19/14, 23:26

  18. Markus Klein uploaded patch set 10 11/19/14, 23:31

  19. Markus Klein uploaded patch set 11 11/19/14, 23:38

  20. Markus Klein voted on patch set 11 CR +1 V +1 11/19/14, 23:57

  21. Frank Nägler voted on patch set 11 V +2 CR +2 11/20/14, 08:18

  22. Frank Nägler merged patch set 11 11/20/14, 08:18