34348[TASK] Twitter Bootstrap EXT:beuser follow up
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Markus Klein +1
-
Verified V +2
- Frank Nägler +2
- Markus Klein +1
Issues 1
Files 11
- typo3/sysext/beuser/Classes/Domain/Model/BackendUser.php11+17 −0
- typo3/sysext/beuser/Classes/ViewHelpers/IssueCommandViewHelper.php+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/RemoveUserViewHelper.php+14 −6
- typo3/sysext/beuser/Classes/ViewHelpers/SwitchUserViewHelper.php+13 −6
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/IndexListRow.html5+15 −19
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/OnlineListRow.html+23 −21
- typo3/sysext/beuser/Resources/Private/Partials/Filters/BackendUser/Index.html+58 −38
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Compare.html+22 −29
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Index.html+11 −15
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Online.html+4 −12
- typo3/sysext/beuser/Resources/Public/Css/style.css+2 −5
Review log 22
-
Mathias Schreiber uploaded patch set 1 11/19/14, 15:10
-
Mathias Schreiber uploaded patch set 2 11/19/14, 16:23
-
Mathias Schreiber uploaded patch set 3 11/19/14, 16:49
-
Frank Nägler commented on patch set 3 CR -1 11/19/14, 18:09
on it, will push a new set soonBackendUser.php:50??? -
Wouter Wolters commented on patch set 3 CR -1 11/19/14, 18:10
This are 3 patches in one.. Please seperate them -
Mathias Schreiber commented on patch set 3 11/19/14, 18:27
can you explain which 3 parts you mean? All I do is style the thing :)BackendUser.php:50Replycan't extbase do this? -
Wouter Wolters commented on patch set 3 11/19/14, 18:33
Ah hit the button to soon. 1. add button group 2. restyle the form 3. implement the check to be unable to disable yourself and this is IMO not a cleanup -
Frank Nägler uploaded patch set 4 11/19/14, 20:24
-
Markus Klein commented on patch set 4 CR -1 11/19/14, 22:16
BackendUser.php:127CheckBackendUser.php:128boolBackendUser.php:131=== maybe?BackendUser.php:131getter for the global pleaseBackendUser.php:131no need for that. the expression already has a boolean result!IndexListRow.html:16translation gone?IndexListRow.html:22should be lowercased isCurr... maybe it works like this, but for consistency -
Andreas Kienast uploaded patch set 5 11/19/14, 22:18
-
Andreas Kienast uploaded patch set 6 11/19/14, 22:21
-
Markus Klein commented on patch set 6 CR -1 11/19/14, 22:27
BackendUser.php:50@transientBackendUser.php:52The property is unusedBackendUser.php:131isCurrentlyLoggedIn()BackendUser.php:132int cast for safety -
Markus Klein commented on patch set 6 11/19/14, 22:29
IndexListRow.html:21tabs -
Markus Klein commented on patch set 6 V -1 11/19/14, 22:33
IndexListRow.html:16translation missingIndexListRow.html:34invalid xml, use inline format instead -
Markus Klein uploaded patch set 7 11/19/14, 22:48
-
Markus Klein uploaded patch set 8 11/19/14, 23:21
-
Markus Klein uploaded patch set 9 11/19/14, 23:26
-
Markus Klein uploaded patch set 10 11/19/14, 23:31
-
Markus Klein uploaded patch set 11 11/19/14, 23:38
-
Markus Klein voted on patch set 11 CR +1 V +1 11/19/14, 23:57
-
Frank Nägler voted on patch set 11 V +2 CR +2 11/20/14, 08:18
-
Frank Nägler merged patch set 11 11/20/14, 08:18