Review main Merged

34383[BUGFIX] Remove unused files_upload

Alexander Opitz CR +2 V +2 Easy +0 −8 updated 11/20/14, 16:06

Commit message

Removing the non existing file_upload permissions from
be_user/be_groups TCA field file_permissions.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Markus Klein +1
  • Verified V +2
    • Markus Klein +2
    • Helmut Hummel +1

Issues 1

Files 3

Review log 10

  1. Alexander Opitz uploaded patch set 1 11/20/14, 11:15

  2. Markus Klein commented on patch set 1 11/20/14, 11:18

    locallang_tca.xlf:99

    we can't remove labels on 6.2, right?
  3. Helmut Hummel commented on patch set 1 CR +2 V +1 11/20/14, 11:25

    locallang_tca.xlf:99 Reply

    We should remove this label, even for 6.2 The impact is, that it disappears from the translation ui, which is wanted in this case.
  4. Wouter Wolters voted on patch set 1 CR +1 11/20/14, 11:33

  5. Markus Klein commented on patch set 1 CR +1 11/20/14, 11:41

    locallang_tca.xlf:99 Reply

    My thought was more in direction of 6.1 and 6.0. Do they use/have this label?
  6. Benni Mack voted on patch set 1 CR +2 11/20/14, 13:03

  7. Helmut Hummel commented on patch set 1 11/20/14, 15:48

    locallang_tca.xlf:99 Reply

    nope, labels were introduced in 6.2
  8. Markus Klein voted on patch set 1 V +2 11/20/14, 16:05

  9. Markus Klein merged patch set 1 11/20/14, 16:05

  10. Markus Klein commented on patch set 2 11/20/14, 16:06

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit c7d72d93372863b16cee10ff2520c9c2aaf0abf0