3440[FEATURE] Improve wizard for creating new records
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Kay Strobach +1
- Philipp Gampe +1
- Christian Müller +1
-
Verified V +2
- Christian Kuhn +2
- Kay Strobach +1
- Philipp Gampe +1
Issues 1
Files 1
Review log 19
-
Mario Rimann commented on patch set 1 07/31/11, 14:23
I would prefer that you didn't submit this I agree with the first reviewer, turning the condition around will make it better readable. Besides that, great idea and solution! -
Mario Rimann commented on patch set 2 07/31/11, 14:23
Looks good to me, but someone else must approve Well done! -
Christian Müller commented on patch set 2 07/31/11, 14:23
Looks good to me, but someone else must approve sorry, for me it looked like part of the patch, as it isn't no need to hold back +1. But of course would be nice to fix the parenthesis ;) -
Christian Müller commented on patch set 2 07/31/11, 14:23
(1 inline comment) Very nice, +1 as soon as the nitpick is done with ;) -
Xavier Perseguers commented on patch set 2 2 comments 07/31/11, 14:23
Looks good to me, but someone else must approve Full +1 by reading after taking my comments into account. thx -
Georg Ringer uploaded patch set 2 07/31/11, 14:23
-
Christian Müller commented on patch set 3 07/31/11, 14:23
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 3 07/31/11, 14:23
Docementation is missing! Please add it here, or in the forge issue so that the committer can take care of adding it to the wiki! -
Christian Kuhn commented on patch set 3 07/31/11, 14:23
I like the patch and it works. I'll now write the missing documentation and will merge it. -
Christian Kuhn commented on patch set 3 V 0 07/31/11, 14:23
by team member; Looks good to me, approved Added to pending 4.6 documentation of doc_core_api. Merged. -
Georg Ringer uploaded patch set 3 07/31/11, 14:23
-
Kay Strobach commented on patch set 3 07/31/11, 14:23
Verified; Looks good to me, but someone else must approve cool idea -
Philipp Gampe commented on patch set 1 07/31/11, 14:23
I would prefer that you didn't submit this see commentdb_new.php:554Please turn the condition around: if isset property use property otherwise fall back to default I was really confused and had to read it three times. -
Philipp Gampe commented on patch set 2 07/31/11, 14:23
Verified; Looks good to me, but someone else must approve Very nice... while testing, I found out that you can use this feature to also create more than one group per extension. Just specify a non existing extension key. -
Philipp Gampe commented on patch set 3 07/31/11, 14:23
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 07/31/11, 14:23
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1293/ : SUCCESS -
Mr. Jenkins commented on patch set 2 07/31/11, 14:23
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1295/ : SUCCESS -
Mr. Jenkins commented on patch set 3 07/31/11, 14:23
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1413/ : SUCCESS -
Christian Kuhn merged patch set 3 07/31/11, 14:23