Review main Merged

3440[FEATURE] Improve wizard for creating new records

Georg Ringer CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

Add the possibility to group records together, even
when the extension key is a different one.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Kay Strobach +1
    • Philipp Gampe +1
    • Christian Müller +1
  • Verified V +2
    • Christian Kuhn +2
    • Kay Strobach +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 19

  1. Mario Rimann commented on patch set 1 07/31/11, 14:23

    I would prefer that you didn't submit this I agree with the first reviewer, turning the condition around will make it better readable. Besides that, great idea and solution!
  2. Mario Rimann commented on patch set 2 07/31/11, 14:23

    Looks good to me, but someone else must approve Well done!
  3. Christian Müller commented on patch set 2 07/31/11, 14:23

    Looks good to me, but someone else must approve sorry, for me it looked like part of the patch, as it isn't no need to hold back +1. But of course would be nice to fix the parenthesis ;)
  4. Christian Müller commented on patch set 2 07/31/11, 14:23

    (1 inline comment) Very nice, +1 as soon as the nitpick is done with ;)
  5. Xavier Perseguers commented on patch set 2 2 comments 07/31/11, 14:23

    Looks good to me, but someone else must approve Full +1 by reading after taking my comments into account. thx
  6. Georg Ringer uploaded patch set 2 07/31/11, 14:23

  7. Christian Müller commented on patch set 3 07/31/11, 14:23

    Looks good to me, but someone else must approve
  8. Christian Kuhn commented on patch set 3 07/31/11, 14:23

    Docementation is missing! Please add it here, or in the forge issue so that the committer can take care of adding it to the wiki!
  9. Christian Kuhn commented on patch set 3 07/31/11, 14:23

    I like the patch and it works. I'll now write the missing documentation and will merge it.
  10. Christian Kuhn commented on patch set 3 V 0 07/31/11, 14:23

    by team member; Looks good to me, approved Added to pending 4.6 documentation of doc_core_api. Merged.
  11. Georg Ringer uploaded patch set 3 07/31/11, 14:23

  12. Kay Strobach commented on patch set 3 07/31/11, 14:23

    Verified; Looks good to me, but someone else must approve cool idea
  13. Philipp Gampe commented on patch set 1 07/31/11, 14:23

    I would prefer that you didn't submit this see comment

    db_new.php:554

    Please turn the condition around: if isset property use property otherwise fall back to default I was really confused and had to read it three times.
  14. Philipp Gampe commented on patch set 2 07/31/11, 14:23

    Verified; Looks good to me, but someone else must approve Very nice... while testing, I found out that you can use this feature to also create more than one group per extension. Just specify a non existing extension key.
  15. Philipp Gampe commented on patch set 3 07/31/11, 14:23

    Verified; Looks good to me, but someone else must approve
  16. Mr. Jenkins commented on patch set 1 07/31/11, 14:23

  17. Mr. Jenkins commented on patch set 2 07/31/11, 14:23

  18. Mr. Jenkins commented on patch set 3 07/31/11, 14:23

  19. Christian Kuhn merged patch set 3 07/31/11, 14:23