Review main Merged

34414[TASK] Use fully qualified name resolution in PHP 5.5

Wouter Wolters CR +2 V +2 Hard +397 −396 updated 11/21/14, 11:40

Commit message

Since PHP 5.5 is a requirement, calls with the objectManager
should use the ::class construct instead of a string argument.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1

Issues 1

Files 126

Show 106 more files

Review log 19

  1. Wouter Wolters uploaded patch set 1 11/20/14, 21:30

  2. Markus Klein commented on patch set 1 CR -1 V -1 11/20/14, 21:45

    Please document on forge which regexp you used for the replacement.

    AjaxController.php:138

    mistake here

    StepController.php:144

    and here

    ToolController.php:175

    here too
  3. Wouter Wolters commented on patch set 1 11/20/14, 21:48

    Done. Your findings needs manual adaption back to the string variant. We had the same in Xavier his patch.
  4. Markus Klein uploaded patch set 2 11/20/14, 21:48

  5. Markus Klein commented on patch set 2 CR -1 11/20/14, 21:51

    one more occurrence missing regexp which excludes the problematic things ->get\s*\(\s*('|")\\*\w+(\\+\w+)+('|")
  6. Markus Klein commented on patch set 2 V -1 11/20/14, 21:52

    one wrong version in a test with '\\asdf' missing and some cases with linebreaks
  7. Markus Klein commented on patch set 2 11/20/14, 21:52

    will followup
  8. Markus Klein uploaded patch set 3 11/20/14, 22:04

  9. Markus Klein voted on patch set 3 CR +1 V +1 11/20/14, 22:07

  10. Markus Klein uploaded patch set 4 11/20/14, 22:08

  11. Markus Klein commented on patch set 4 CR +1 V +1 11/20/14, 22:09

    found one more glitch
  12. Wouter Wolters commented on patch set 4 11/20/14, 22:14

    Thanks Markus!
  13. Christian Kuhn commented on patch set 4 11/20/14, 23:01

    woah, big one. looks good on reading, on question, though.

    ext_localconf.php:6

    this goes straight to the signal slot dispatcher. are you sure this works and is b/w compatible?
  14. Markus Klein commented on patch set 4 11/21/14, 11:32

    ext_localconf.php:6 Reply

    since the ::class construct just returns the FQN as string, there's no functional difference. But this line is actually a mistake and should not be in this patch. will remove it
  15. Markus Klein uploaded patch set 5 11/21/14, 11:33

  16. Markus Klein voted on patch set 5 CR +1 V +1 11/21/14, 11:34

  17. Christian Kuhn commented on patch set 5 11/21/14, 11:37

    gimme a second ;)
  18. Christian Kuhn commented on patch set 5 CR +2 V +2 11/21/14, 11:40

    Read through it twice - yesterday evening and now. Looks good to me ... Let's go for it before it breaks.
  19. Christian Kuhn merged patch set 5 11/21/14, 11:40