34414[TASK] Use fully qualified name resolution in PHP 5.5
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Klein +1
-
Verified V +2
- Christian Kuhn +2
- Markus Klein +1
Issues 1
Files 126
- typo3/sysext/about/Classes/Domain/Repository/ExtensionRepository.php+2 −2
- typo3/sysext/backend/Classes/Controller/LoginController.php+1 −1
- typo3/sysext/belog/Classes/Controller/AbstractController.php+2 −2
- typo3/sysext/belog/Classes/Domain/Repository/HistoryEntryRepository.php+1 −1
- typo3/sysext/belog/Classes/Domain/Repository/LogEntryRepository.php+1 −1
- typo3/sysext/belog/Classes/Domain/Repository/WorkspaceRepository.php+1 −1
- typo3/sysext/beuser/Classes/Hook/SwitchBackUserHook.php+1 −1
- typo3/sysext/beuser/Classes/Service/ModuleDataStorageService.php+1 −1
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/Service/FileProcessingService.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+1 −1
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-61361-FallbackTemplatePathsForFluidStandaloneView.rst+1 −1
- typo3/sysext/core/Resources/PHP/TYPO3.Flow/Classes/TYPO3/Flow/Package/PackageManager.php+5 −5
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Controller/AbstractController.php+2 −2
- typo3/sysext/core/Tests/FunctionalTestCaseBootstrapUtility.php+1 −1
- typo3/sysext/documentation/Classes/Domain/Repository/DocumentRepository.php+6 −6
- typo3/sysext/documentation/Classes/Slots/ExtensionManager.php+2 −2
- typo3/sysext/extbase/Classes/Configuration/ConfigurationManager.php+2 −2
Show 106 more files
- typo3/sysext/extbase/Classes/Core/Bootstrap.php+5 −5
- typo3/sysext/extbase/Classes/Core/ModuleRunner.php+1 −1
- typo3/sysext/extbase/Classes/Domain/Repository/BackendUserGroupRepository.php+1 −1
- typo3/sysext/extbase/Classes/Domain/Repository/BackendUserRepository.php+1 −1
- typo3/sysext/extbase/Classes/Domain/Repository/CategoryRepository.php+1 −1
- typo3/sysext/extbase/Classes/Domain/Repository/FileMountRepository.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Cli/Command.php+2 −2
- typo3/sysext/extbase/Classes/Mvc/Cli/CommandManager.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Cli/Request.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Cli/RequestBuilder.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Cli/RequestHandler.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/AbstractController.php+4 −4
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+3 −3
- typo3/sysext/extbase/Classes/Mvc/Controller/Arguments.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/CommandController.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Web/BackendRequestHandler.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Web/FrontendRequestHandler.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Web/RequestBuilder.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapFactory.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/QueryObjectModelFactory.php+14 −14
- typo3/sysext/extbase/Classes/Persistence/Generic/Query.php+4 −4
- typo3/sysext/extbase/Classes/Persistence/Generic/QueryFactory.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/QueryResult.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Typo3QuerySettings.php+1 −1
- typo3/sysext/extbase/Classes/Reflection/ReflectionService.php+1 −1
- typo3/sysext/extbase/Classes/Scheduler/FieldProvider.php+2 −2
- typo3/sysext/extbase/Classes/Scheduler/Task.php+4 −4
- typo3/sysext/extbase/Classes/Scheduler/TaskExecutor.php+6 −6
- typo3/sysext/extbase/Classes/Utility/LocalizationUtility.php+1 −1
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/AddTest.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/CountTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/InTest.php+5 −5
- typo3/sysext/extbase/Tests/Functional/Persistence/OperatorTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/QueryParserTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php+19 −19
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslationTest.php+1 −1
- typo3/sysext/extensionmanager/Classes/Command/ExtensionCommandController.php+2 −2
- typo3/sysext/extensionmanager/Classes/Controller/ConfigurationController.php+1 −1
- typo3/sysext/extensionmanager/Classes/Controller/ListController.php+2 −2
- typo3/sysext/extensionmanager/Classes/Controller/UpdateScriptController.php+1 −1
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php+1 −1
- typo3/sysext/extensionmanager/Classes/Domain/Repository/ConfigurationItemRepository.php+5 −5
- typo3/sysext/extensionmanager/Classes/Domain/Repository/ExtensionRepository.php+1 −1
- typo3/sysext/extensionmanager/Classes/Domain/Repository/RepositoryRepository.php+1 −1
- typo3/sysext/extensionmanager/Classes/Report/ExtensionStatus.php+8 −8
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php+1 −1
- typo3/sysext/extensionmanager/Classes/Task/UpdateExtensionListTask.php+2 −2
- typo3/sysext/extensionmanager/Classes/Utility/Importer/ExtensionListUtility.php+3 −3
- typo3/sysext/extensionmanager/Classes/Utility/Repository/Helper.php+3 −3
- typo3/sysext/extensionmanager/Classes/Utility/ConfigurationUtility.php+2 −2
- typo3/sysext/extensionmanager/Classes/Utility/ExtensionModelUtility.php+2 −2
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+3 −3
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Form/TypoScriptConstantsViewHelper.php+5 −3
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ImageViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ToggleExtensionInstallationStateViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/UpdateScriptViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/Compatibility/DocbookGeneratorService.php+2 −2
- typo3/sysext/fluid/Classes/Compatibility/TemplateParserBuilder.php+1 −1
- typo3/sysext/fluid/Classes/Core/Parser/Interceptor/Escape.php+2 −2
- typo3/sysext/fluid/Classes/Core/Parser/TemplateParser.php+10 −10
- typo3/sysext/fluid/Classes/Core/Widget/AbstractWidgetViewHelper.php+4 −4
- typo3/sysext/fluid/Classes/Core/Widget/Bootstrap.php+3 −3
- typo3/sysext/fluid/Classes/Core/Widget/WidgetRequestBuilder.php+1 −1
- typo3/sysext/fluid/Classes/Core/Widget/WidgetRequestHandler.php+1 −1
- typo3/sysext/fluid/Classes/View/AbstractTemplateView.php+4 −4
- typo3/sysext/fluid/Classes/View/StandaloneView.php+7 −7
- typo3/sysext/fluid/Classes/View/TemplateView.php+1 −1
- typo3/sysext/install/Classes/Controller/Action/Ajax/ClearCache.php+1 −1
- typo3/sysext/install/Classes/Controller/Action/Ajax/CoreUpdateIsUpdateAvailable.php+1 −1
- typo3/sysext/install/Classes/Controller/Action/Ajax/EnvironmentStatus.php+2 −2
- typo3/sysext/install/Classes/Controller/Action/Ajax/FolderStatus.php+3 −3
- typo3/sysext/install/Classes/Controller/Action/Common/InstallToolDisabledAction.php+2 −2
- typo3/sysext/install/Classes/Controller/Action/Step/DatabaseConnect.php+12 −12
- typo3/sysext/install/Classes/Controller/Action/Step/DatabaseData.php+4 −4
- typo3/sysext/install/Classes/Controller/Action/Step/DatabaseSelect.php+6 −6
- typo3/sysext/install/Classes/Controller/Action/Step/DefaultConfiguration.php+3 −3
- typo3/sysext/install/Classes/Controller/Action/Step/EnvironmentAndFolders.php+7 −7
- typo3/sysext/install/Classes/Controller/Action/Tool/AllConfiguration.php+3 −3
- typo3/sysext/install/Classes/Controller/Action/Tool/CleanUp.php+4 −4
- typo3/sysext/install/Classes/Controller/Action/Tool/Configuration.php+2 −2
- typo3/sysext/install/Classes/Controller/Action/Tool/FolderStructure.php+3 −3
- typo3/sysext/install/Classes/Controller/Action/Tool/ImportantActions.php+26 −26
- typo3/sysext/install/Classes/Controller/Action/Tool/SystemEnvironment.php+2 −2
- typo3/sysext/install/Classes/Controller/Action/Tool/TestSetup.php+14 −14
- typo3/sysext/install/Classes/Controller/Action/Tool/UpgradeWizard.php+8 −8
- typo3/sysext/install/Classes/Controller/Action/AbstractAction.php+2 −2
- typo3/sysext/install/Classes/Controller/AbstractController.php+13 −13
- typo3/sysext/install/Classes/Controller/StepController.php1+8 −9
- typo3/sysext/install/Classes/Service/ClearCacheService.php+1 −1
- typo3/sysext/install/Classes/Service/CoreUpdateService.php+24 −24
- typo3/sysext/install/Classes/Service/SqlExpectedSchemaService.php+1 −1
- typo3/sysext/install/Classes/Updates/AbstractDatabaseSchemaUpdate.php+2 −2
- typo3/sysext/install/Classes/View/FailsafeView.php+1 −1
- typo3/sysext/install/Classes/View/StandaloneView.php+6 −6
- typo3/sysext/lang/Classes/Command/LanguageCommandController.php+3 −3
- typo3/sysext/lang/Classes/Controller/LanguageController.php+1 −1
- typo3/sysext/lang/Classes/Domain/Repository/ExtensionRepository.php+1 −1
- typo3/sysext/lang/Classes/Domain/Repository/LanguageRepository.php+1 −1
- typo3/sysext/sys_note/Classes/Domain/Repository/SysNoteRepository.php+1 −1
- typo3/sysext/workspaces/Classes/Controller/AbstractController.php+2 −2
- typo3/sysext/workspaces/Classes/Service/AdditionalColumnService.php+1 −1
- typo3/sysext/workspaces/Classes/Service/AdditionalResourceService.php+1 −1
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+2 −2
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+1 −1
Review log 19
-
Wouter Wolters uploaded patch set 1 11/20/14, 21:30
-
Markus Klein commented on patch set 1 CR -1 V -1 11/20/14, 21:45
Please document on forge which regexp you used for the replacement.AjaxController.php:138mistake hereStepController.php:144and hereToolController.php:175here too -
Wouter Wolters commented on patch set 1 11/20/14, 21:48
Done. Your findings needs manual adaption back to the string variant. We had the same in Xavier his patch. -
Markus Klein uploaded patch set 2 11/20/14, 21:48
-
Markus Klein commented on patch set 2 CR -1 11/20/14, 21:51
one more occurrence missing regexp which excludes the problematic things ->get\s*\(\s*('|")\\*\w+(\\+\w+)+('|") -
Markus Klein commented on patch set 2 V -1 11/20/14, 21:52
one wrong version in a test with '\\asdf' missing and some cases with linebreaks -
Markus Klein commented on patch set 2 11/20/14, 21:52
will followup -
Markus Klein uploaded patch set 3 11/20/14, 22:04
-
Markus Klein voted on patch set 3 CR +1 V +1 11/20/14, 22:07
-
Markus Klein uploaded patch set 4 11/20/14, 22:08
-
Markus Klein commented on patch set 4 CR +1 V +1 11/20/14, 22:09
found one more glitch -
Wouter Wolters commented on patch set 4 11/20/14, 22:14
Thanks Markus! -
Christian Kuhn commented on patch set 4 11/20/14, 23:01
woah, big one. looks good on reading, on question, though.ext_localconf.php:6this goes straight to the signal slot dispatcher. are you sure this works and is b/w compatible? -
Markus Klein commented on patch set 4 11/21/14, 11:32
ext_localconf.php:6Replysince the ::class construct just returns the FQN as string, there's no functional difference. But this line is actually a mistake and should not be in this patch. will remove it -
Markus Klein uploaded patch set 5 11/21/14, 11:33
-
Markus Klein voted on patch set 5 CR +1 V +1 11/21/14, 11:34
-
Christian Kuhn commented on patch set 5 11/21/14, 11:37
gimme a second ;) -
Christian Kuhn commented on patch set 5 CR +2 V +2 11/21/14, 11:40
Read through it twice - yesterday evening and now. Looks good to me ... Let's go for it before it breaks. -
Christian Kuhn merged patch set 5 11/21/14, 11:40