Review main Merged

34440[CLEANUP] Improve checkboxes in EXT:scheduler

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 11/22/14, 11:33

Commit message

The checkboxes in EXT:scheduler are too big. Change the CSS class to
fix this.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1

Issues 1

Files 1

Review log 8

  1. Andreas Kienast uploaded patch set 1 11/21/14, 11:06

  2. Andreas Kienast wrote 11/21/14, 15:16

    Topic set to ui
  3. Benni Mack commented on patch set 1 CR +1 V +1 11/22/14, 08:54

    I like it. Maybe we can move the labels of the checkboxes next to the checkboxes instead of above in a next patch). What do you think?
  4. Benni Mack uploaded patch set 2 11/22/14, 10:20

  5. Benni Mack voted on patch set 2 CR +1 V +1 11/22/14, 10:21

  6. Andreas Kienast commented on patch set 2 11/22/14, 10:32

    Hi Benni. I agree with moving the checkboxes next to the labels, but first we have to refactor the CSH html. The checkbox can only be left to the label, bu then the label is not bold anymore. If we put the checkbox to the right, it's positioned over the label.
  7. Wouter Wolters voted on patch set 2 V +2 CR +2 11/22/14, 11:32

  8. Wouter Wolters merged patch set 2 11/22/14, 11:33