Review TYPO3_6-2 Merged

34458[BUGFIX] Redirect on direct access to overlaid mountpoint

Alexander Stehlik CR +2 V +2 Normal +82 −31 updated 12/05/14, 23:47

Commit message

When the user directly accesses a page that is a mountpoint that
should be overlaid with the contents of the mounted page, he will
be redirected to the target page within the mounpoint context.

Review

  • Code review CR +2
    • Markus Klein +2
    • Alexander Stehlik +1
  • Verified V +2
    • Markus Klein +2
    • Alexander Stehlik +1

Issues 1

Files 2

Review log 9

  1. Alexander Stehlik uploaded patch set 1 11/21/14, 17:38

  2. Markus Klein voted on patch set 1 CR +1 11/21/14, 17:46

  3. Alexander Stehlik uploaded patch set 2 12/05/14, 17:35

  4. Alexander Stehlik uploaded patch set 3 12/05/14, 18:00

  5. Alexander Stehlik commented on patch set 3 CR +1 V +1 12/05/14, 18:01

    Removed the strict comparison with the Page doktypes because the database row contains a string and the DOKTYPE constants is int. This can not work and needs to be fixed in master as well I guess.
  6. Markus Klein commented on patch set 3 CR +1 V +1 12/05/14, 23:44

    Can you push a followup for master for the comparision as well please?
  7. Markus Klein commented on patch set 3 12/05/14, 23:45

    Ah sorry, just found the followup, thx
  8. Markus Klein voted on patch set 3 CR +2 V +2 12/05/14, 23:47

  9. Markus Klein merged patch set 3 12/05/14, 23:47