Review main Merged

34469[TASK] Cleanup BackendController.php (part 1)

Benni Mack CR +2 V +2 Normal +33 −87 updated 11/22/14, 19:25

Commit message

The backend controller has some leftover
code. First, the main output is moved
to a standalone fluid view.

Additionally, the UserMenu.js is not
needed anymore, as Bootstrap Dropdown
is taking care of its logic.

Some minor code logic cleanup is also
added, as well as a @todo note.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Andreas Kienast +1

Issues 1

Files 3

Review log 4

  1. Benni Mack uploaded patch set 1 11/22/14, 18:45

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 11/22/14, 18:55

  3. Wouter Wolters voted on patch set 1 V +2 CR +2 11/22/14, 19:25

  4. Wouter Wolters merged patch set 1 11/22/14, 19:25