Review main Abandoned Breaking

34552[!!!][TASK] Remove support for "global" extensions

Benni Mack CR 0 V 0 Normal +38 −15 updated 12/12/14, 20:59

Commit message

The functionality of "global" extensions,
which are extensions that reside under typo3/ext/
is removed, as this concept is not usable
anymore and has a lot of side effects (core
self update functionality etc).

The option
$TYPO3_CONF_VARS['EXT']['allowGlobalInstall']
is removed as well, as it is not needed anymore.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 7

Review log 34

Show 9 earlier messages
  1. Benni Mack uploaded patch set 1 11/24/14, 14:48

  2. Stefan Neufeind voted on patch set 1 CR +1 11/24/14, 15:49

  3. Stefan Froemken commented on patch set 1 11/25/14, 21:01

    If a feature has sideeffects we remove it. Is this our new approach? Don't forget that we are a business CMS and we can run multiple installations on ONE core. Are we really sure that we want to remove this feature?
  4. Stefan Neufeind commented on patch set 1 11/26/14, 00:12

    @StefanF: Sorry for an honest "reaction" but reaction: Do you volunteer to fix and maintain it? I personally don't see a problem to either put things in the old global directory (okay, I *never* used it) or use the local directory for that. You can even use symlinks if you desire. Imho having extensions in a central place (and maybe updating them without updating DB etc.) is always calling for trouble a bit ...
  5. Benni Mack commented on patch set 1 12/04/14, 22:17

    Stefan, thanks for your reply, but these are two concepts which don't work together. Core Update and Global Extensions (which I know 1 person using it with 4.5) do not work together. If you fix the one thing, then you can not use Core Updater anymore.
  6. Helmut Hummel commented on patch set 1 CR -1 12/06/14, 14:23

    Also package manager change is missing

    locallang_csh_em.xlf:63

    the label change will affect released versions
  7. Benni Mack commented on patch set 1 12/07/14, 08:42

    hey helmut. can you point me to the package manager change? I will also remove the XLF change then in the next patchset.
  8. Helmut Hummel uploaded patch set 2 12/07/14, 10:00

  9. Helmut Hummel commented on patch set 2 CR -1 12/07/14, 10:06

    missed a place in package manager
  1. Helmut Hummel uploaded patch set 3 12/07/14, 10:06

  2. Benni Mack uploaded patch set 4 12/08/14, 06:47

  3. Sebastian Fischer voted on patch set 4 CR +1 12/08/14, 09:58

  4. Peter Russ commented on patch set 4 CR -1 12/08/14, 10:48

    We use GLOBAL as a common base for different installations. Removing this would generate a major rework for the whole development and deployment process.
  5. Mathias Brodala voted on patch set 4 CR +1 12/08/14, 10:53

  6. Alexander Opitz voted on patch set 4 CR +1 12/08/14, 11:20

  7. Oliver Klee voted on patch set 4 CR +1 12/08/14, 11:46

  8. Martin Wiederkehr commented on patch set 4 CR -1 12/08/14, 12:38

    We use this feature in almost every installation to provide global functionality. The main advantage for us is to provide global functionality which is maintainable outside the team and a sprint, mainly for security reasons.
  9. Peter Niederlag voted on patch set 4 CR -1 12/08/14, 15:17

  10. Peter Niederlag voted on patch set 4 CR +1 12/08/14, 15:17

  11. Stefan Neufeind commented on patch set 4 CR +1 12/08/14, 15:42

    According to Benni it's not really possible to support this any longer (without bigger problems). Thus I'm fine with the removal
  12. Kasper Ligaard commented on patch set 4 CR -1 12/08/14, 17:07

    We use global as a common base for many installations. No need to destroy this feature.
  13. Jo Hasenau commented on patch set 4 CR -1 12/08/14, 17:23

  14. Wouter Wolters commented on patch set 4 CR +1 12/08/14, 17:48

    Never used the feature.
  15. Mathias Brodala commented on patch set 4 12/09/14, 07:50

    Since it was posted in the forum but not here: one suggestion seems to be moving the directory of global extensions out of the TYPO3 CMS directory, thus allow for really easy core updates.
  16. Jigal van Hemert commented on patch set 4 CR -1 12/09/14, 08:37

    Even though I've never used the feature myself I see a valid use case. There are several agencies that provide patched versions of the core to their clients. In these cases it would only be logical to provide also globally installed extensions for these clients. The argument that it's not easy to update the core with these globally installed extensions from for example the Install Tool is already not valid for these patched cores. Composer is a tool for developers and some deployment systems. Because plenty of installation do not have (unlimited) access to external websites we simply have to supply a complete downloadable package. Best solution: - keep the feature for globally installed extensions - if it's a problem with other features (composer related, core updates from Install Tool), it's safe to ignore the globally installed extensions or only display a warning.
  17. Michael Stucki commented on patch set 4 CR -1 12/09/14, 10:01

    I'm also in favour for not removing this, at least not until there is an alternative possibility which provides the same result. The use case here is that hosters want to provide their own modules (think of an authentication module which is used on all sites of a webserver). I don't see how this could be achieved without having to install the extension into every site separately. @all: The question here is not if you are currently using this feature or not. Think of those who are using it. As far as I could see the feature is used by several users. So before thinking about removing it, an alternative approach should be provided. see http://forum.typo3.org/index.php/t/207538/
  18. Benni Mack commented on patch set 4 CR -2 12/09/14, 10:02

    thanks for your insights and discussions. The poll shows me that this feature (or at least the idea of the global extensions) is still way more important as I thought!
  19. Stefan Neufeind commented on patch set 4 12/09/14, 10:19

    So could somebody who "wants it" please step forward and take care of it?
  20. Michael Stucki commented on patch set 4 12/09/14, 10:24

    Sorry Stefan, this is not how things should work. People use CMS because of the current feature set. It's not their task to make sure that these features are kept. As a developer, it's your job to make sure that every change is an improvement.
  21. Franz Holzinger commented on patch set 4 CR -1 12/09/14, 14:00

    I have been using this feature since more than 10 years. I use all extensions as global. If I try out a new version of an extension, then I install it as local and test it. Then I can easily remove it again, if it does not work. And the older version of that extension remains in the global folder. So I can easily go back again. I would need another feature if you remove this one.
  22. Alexander Opitz commented on patch set 4 12/09/14, 14:27

    @Franz Holzinger You don't know the option to install another version of an extension inside the extension manager?
  23. Franz Holzinger commented on patch set 4 CR 0 12/09/14, 14:32

    @Alexander Opitz: I do not get your point. I know that I can choose the version of an extension from the EM. However I do not want to overwrite the already installed extension before I have tested the newer version. I want to save time to go back to the older version again.
  24. Michael Stucki commented on patch set 4 12/09/14, 14:42

    Tbh. I think that's a very special use case. Please don't start a discussion about that right now, and also don't neglect it because of one person having a really weird use case for it. Thanks! :-)
  25. Benni Mack abandoned the change 12/12/14, 20:59

    I abandon this change as this solution is not the right way. Thanks a lot for all the feedback!