3456[FEATURE] Generate cHash only if needed
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Stefan Neufeind +1
- Björn Pedersen +1
- Dmitry Dulepov +1
- Benni Mack +1
-
Verified V +2
- Xavier Perseguers +2
- Popy +1
- Dmitry Dulepov +1
Issues 1
Files 1
Review log 25
-
Markus Klein commented on patch set 2 10/10/11, 10:14
Looks good to me, but someone else must approveclass.tslib_content.php:5567Maybe also change this here to strlen(trim($params, '& '))class.tslib_content.php:5567Maybe also change this here to strlen(trim($params, '& ')) -
Popy commented on patch set 2 10/10/11, 10:14
Ok, I can try to fix that without modifying the behavior, so generateCHash will not be used. Your patch can't work, as $params is a string (and has already been checked). If i win my fight against Git, i'll commit another patch.I would like to keep my nickname somethere, do you agree on something like : "Author: Pierre Dudoret, aka Popy <popy.dev@gmail.com>" ? -
Mario Rimann commented on patch set 3 10/10/11, 10:14
(1 inline comment) -
Björn Pedersen commented on patch set 3 10/10/11, 10:14
strongly coupled to: https://review.typo3.org/#change,4704 -
Dmitry Dulepov commented on patch set 3 10/10/11, 10:14
Looks good to me, but someone else must approve I will test this later. The patch is especially helpful when you use RealURL. -
Björn Pedersen commented on patch set 4 10/10/11, 10:14
Looks good to me, but someone else must approve -
Dmitry Dulepov uploaded patch set 4 10/10/11, 10:14
-
Dmitry Dulepov commented on patch set 4 10/10/11, 10:14
Verified; Looks good to me, but someone else must approve Changed call from self::cHashParams to t3lib_div::cHashParams. Behavior verified. I will push this soon if nobody objects. -
Stefan Neufeind commented on patch set 3 1 comment 10/10/11, 10:14
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 4 10/10/11, 10:14
Looks good to me, but someone else must approve In the light of security maybe we should backport it as well. -
Markus Klein commented on patch set 3 10/10/11, 10:14
(1 inline comment) -
Benni Mack commented on patch set 4 10/10/11, 10:14
Looks good to me, but someone else must approve -
Popy uploaded patch set 3 10/10/11, 10:14
-
Popy commented on patch set 3 10/10/11, 10:14
(1 inline comment) -
Popy voted on patch set 4 V 0 10/10/11, 10:14
-
Xavier Perseguers commented on patch set 4 V 0 10/10/11, 10:14
by team member -
Xavier Perseguers commented on patch set 4 10/10/11, 10:14
Looks good to me, approved Accepted to be integrated because of the flooding security issue that it solves (see BT). -
Georg Ringer commented on patch set 3 10/10/11, 10:14
Looks good to me, but someone else must approve -
Steffen Gebert uploaded patch set 2 10/10/11, 10:14
-
Steffen Gebert commented on patch set 2 10/10/11, 10:14
Popy, please don't change the behavior of existing methods. I just tried to fix this inside tslib_content.php, but did not test it. -
Mr. Jenkins commented on patch set 1 10/10/11, 10:14
Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/1305/ : FAILURE -
Mr. Jenkins commented on patch set 2 10/10/11, 10:14
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1307/ : SUCCESS -
Mr. Jenkins commented on patch set 3 10/10/11, 10:14
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1308/ : SUCCESS -
Mr. Jenkins commented on patch set 4 10/10/11, 10:14
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/2004/ : SUCCESS -
Xavier Perseguers merged patch set 4 10/10/11, 10:14