Review main Merged

34580[BUGFIX] Use Sprite Icon for new Template Button

Benni Mack CR +2 V +2 Easy +5 −1 updated 11/25/14, 12:23

Commit message

The icon in the docheader of
the Template module shows
a "create new extension template"
button which is not done via
SpriteIcon but with an old image.

This is now replaced via a Sprite Icon
and an anchor instead of a button.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Andreas Kienast +1

Issues 1

Files 1

Review log 7

  1. Benni Mack uploaded patch set 1 11/25/14, 08:18

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 11/25/14, 08:30

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 11/25/14, 11:12

  4. Benni Mack voted on patch set 1 CR +2 V +2 11/25/14, 11:12

  5. Benni Mack merged patch set 1 11/25/14, 11:13

  6. Helmut Hummel commented on patch set 2 11/25/14, 11:46

    post -1 due to missing htmlspecialchars()

    TypoScriptTemplateModuleController.php:255

    missing htmlspecialchars()!
  7. Stefan Neufeind commented on patch set 2 11/25/14, 12:23

    TypoScriptTemplateModuleController.php:255 Reply

    thanks. followup is at https://review.typo3.org/34598