Review main Merged

34597[BUGFIX] Replace shortcut item icons with sprites

Benni Mack CR +2 V +2 Easy +11 −9 updated 11/28/14, 07:42

Commit message

If somebody adds shortcuts with several
types, e.g. while editing the contents of a file
or the RTE in full-screen mode or just within
a module, you notice that there are missing
icons and sprites.

The patch changes the image tag to sprite icons.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christoph Hofmann +1
    • Stefan Froemken +1
  • Verified V +2
    • Wouter Wolters +2
    • Christoph Hofmann +1
    • Stefan Froemken +1

Issues 1

Files 2

Review log 11

  1. Benni Mack uploaded patch set 1 11/25/14, 12:09

  2. Benni Mack updated the commit message in patch set 2 11/25/14, 19:59

  3. Stefan Froemken uploaded patch set 3 11/25/14, 20:17

  4. Stefan Froemken updated the commit message in patch set 4 11/25/14, 20:19

  5. Stefan Froemken voted on patch set 4 CR +1 V +1 11/25/14, 20:19

  6. Wouter Wolters voted on patch set 4 V +1 CR +1 11/26/14, 19:40

  7. Christoph Hofmann voted on patch set 4 CR +1 V +1 11/26/14, 19:46

  8. Wouter Wolters voted on patch set 4 V +2 CR +2 11/26/14, 19:48

  9. Wouter Wolters merged patch set 4 11/26/14, 19:48

  10. Frans Saris commented on patch set 5 11/28/14, 07:34

    Will provide a followup

    ShortcutToolbarItem.php:664

    This results in a fatal error when $row = FALSE That is the case when the linked element is deleted
  11. Frans Saris commented on patch set 5 11/28/14, 07:42