Review main Merged

3462[TASK] Add default security settings in .htaccess

Xavier Perseguers CR +2 V +2 Easy +12 −0 updated 06/03/13, 20:49

Commit message

Add a new security section within .htaccess to help users secure their
TYPO3 install:

- Restrict access to deleted files in Recycler directories
- Restrict access to TypoScript files in default templates directories
- Restrict access to Private extension directories

Review

  • Code review CR +2
    • Georg Ringer +2
    • Helmut Hummel +2
  • Verified V +2
    • Georg Ringer +2
    • Helmut Hummel +2

Issues 1

Files 1

Review log 11

  1. Markus Klein commented on patch set 2 07/22/11, 09:00

    (1 inline comment)

    _.htaccess:101

    Who says you have to keep your templates in this folder??? Usually I use fileadmin/layout for instance. We should add a massive hint here, that the admin has to change this to the appropriate folder!
  2. Xavier Perseguers uploaded patch set 2 07/22/11, 09:00

  3. Xavier Perseguers commented on patch set 2 07/22/11, 09:00

    Sorry Helmut, just wanted to make it look like the other configuration lines
  4. Xavier Perseguers commented on patch set 2 07/22/11, 09:00

    It is a basic security setting, nobody forces you to do this but typically if you use TemplaVoilà, the wizard requires this directory to be used. The whole .htaccess is meant as working out of the box with common settings but of course you have to make sure it makes sense for you. You may of course come up with a follow-up to add this notice.
  5. Xavier Perseguers merged patch set 2 07/22/11, 09:00

  6. Helmut Hummel commented on patch set 1 V 0 07/22/11, 09:00

    by team member; Looks good to me, approved Good idea! Tested, works.
  7. Helmut Hummel commented on patch set 2 V 0 07/22/11, 09:00

    by team member; Looks good to me, approved OK, even better :)
  8. Georg Ringer commented on patch set 2 V 0 07/22/11, 09:00

    by team member; Looks good to me, approved
  9. Mr. Jenkins commented on patch set 1 07/22/11, 09:00

  10. Mr. Jenkins commented on patch set 2 07/22/11, 09:00

  11. Markus Klein commented on patch set 2 07/22/11, 09:00

    Then it's ok of course. I didn't know that this is a (partial) requirement in TemplaVoila, since I do not use it. Best, Markus