Review main Merged

34723[BUGFIX] Followup: Replace shortcut item icons with sprites

Frans Saris CR +2 V +2 Easy +1 −1 updated 11/29/14, 14:30

Commit message

If a the linked record of a shortcut is deleted you get a Fatal error
that breaks the BE.

This patch makes sure that the correct variable types are used for
IconUtility::getSpriteIconForRecord()

Review

  • Code review CR +2
    • Frank Nägler +2
    • Andreas Kienast +1
  • Verified V +2
    • Frank Nägler +2
    • Andreas Kienast +1

Issues 1

Files 1

Review log 7

  1. Frans Saris uploaded patch set 1 11/28/14, 07:41

  2. Cedric Ziel commented on patch set 1 11/28/14, 07:48

    ShortcutToolbarItem.php:664

    CGL says space is required next to braces, right?
  3. Frans Saris commented on patch set 1 11/28/14, 08:12

    ShortcutToolbarItem.php:664 Reply

    no, without space
  4. Andreas Kienast commented on patch set 1 CR +1 V +1 11/28/14, 08:43

    How to reproduce (thanks, Frans): "Create a shortcut to a content element. And after that delete that content element"
  5. Frank Nägler voted on patch set 1 V +1 CR +1 11/29/14, 14:30

  6. Frank Nägler voted on patch set 1 V +2 CR +2 11/29/14, 14:30

  7. Frank Nägler merged patch set 1 11/29/14, 14:30