Review TYPO3_4-5 Merged

3475[FEATURE] Move "Appearance" tab before "Access" tab

Xavier Perseguers CR +2 V +2 Normal +43 −43 updated 06/03/13, 20:49

Commit message

The use of settings in the "Appearance" tab are most likely related to
setting in tabs placed before the "Access" tab.

The "Appearance" should be moved before the "Access" tab to give a
correct workflow

Review

  • Code review CR +2
    • Oliver Hader +2
    • Stefan Neufeind +1
  • Verified V +2
    • Oliver Hader +2
    • Stefan Neufeind +1

Issues 1

Files 1

Review log 15

  1. Oliver Hader commented on patch set 1 07/27/11, 11:15

    Looks good to me, approved

    tbl_tt_content.php:1914

    The t3editor modification was not part of the original patchset in master. This need to be rechecked and of course tested for the "html" case... Thanks!
  2. Oliver Hader commented on patch set 1 1 comment 07/27/11, 11:15

    Do not submit See my comments on the t3editor modification and reinvestigate. Thanks!
  3. Xavier Perseguers commented on patch set 1 07/27/11, 11:15

    Just backported the change from trunk where it was accepted by the UX team. This seems to be a real problem for integrators and as such I would suggest to fix it in 4.5 as well but should be accepted/rejected by the 4.5 Release Team of course.
  4. Xavier Perseguers commented on patch set 1 07/27/11, 11:15

    @Eric: this is consistent with 4.6
  5. Xavier Perseguers commented on patch set 1 07/27/11, 11:15

    Just to make sure everybody reading this RFC gets it: goal is not to move again other fields but make it in sync with what has been changed for 4.6 in line with the UX team itself. @JoH yes, this would be worth a small article to explain how to reorder fields to everybody, even if I'm not sure if this would be a good idea to do so because you may drift quite much from the Core itself. But anyway, seems that many users are not aware of some "internals" and explaining it cannot hurt ;-)
  6. Stefan Neufeind commented on patch set 2 07/27/11, 11:15

    Verified; Looks good to me, but someone else must approve already merged for master: http://review.typo3.org/2628
  7. Oliver Hader commented on patch set 2 V 0 07/27/11, 11:15

    by team member; Looks good to me, approved Looks good (better) now... Still on HOLD to get feedback from Ernesto
  8. Xavier Perseguers uploaded patch set 2 07/27/11, 11:15

  9. Georg Ringer commented on patch set 1 V 0 07/27/11, 11:15

    by team member; Looks good to me, approved go on
  10. Eric Chavaillaz commented on patch set 1 V 0 07/27/11, 11:15

    It's ok for me. Just the behaviour tab is after the access tabs.
  11. Dominique Feyer commented on patch set 1 07/27/11, 11:15

    Verified; Looks good to me, but someone else must approve
  12. Jo Hasenau commented on patch set 1 07/27/11, 11:15

    Verified; Looks good to me, but someone else must approve +1 even though it contradicts the principles and rules we tried to follow while redesigning the BE interface. It seems that people still don't get, why it's useful to have the tabs ordered by the "frequency of usage". So as long as you don't move fields of the access tab to one of the 2 tabs in front of it, just because "they have always been there", I'm fine with it. BTW: Could we agree to just explain people how to simply change the order of tabs and fields on their own for future change requests? - This way the "core order" would be stable and reliable, and people don't have to change their mindsets to often, while working with a version of the same branch.
  13. Mr. Jenkins commented on patch set 1 07/27/11, 11:15

  14. Mr. Jenkins commented on patch set 2 07/27/11, 11:15

  15. Oliver Hader merged patch set 2 07/27/11, 11:15