Review main Merged

34775[CLEANUP] ResourceStorageTest needs some love

Helmut Hummel CR +2 V +2 Hard +156 −135 updated 12/04/14, 00:12

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Files 2

Review log 6

  1. Helmut Hummel uploaded patch set 1 11/29/14, 16:48

  2. Frans Saris commented on patch set 1 11/29/14, 17:24

    ResourceStorageTest.php:227

    Maybe also change the setExpectedException to annotations?
  3. Wouter Wolters voted on patch set 1 V +1 CR +1 11/30/14, 13:20

  4. Christian Kuhn commented on patch set 1 CR +2 V +2 11/30/14, 16:48

    ResourceStorageTest.php:227 Reply

    possible yes, but not required.
  5. Christian Kuhn merged patch set 1 11/30/14, 16:48

  6. Markus Klein commented on patch set 2 12/04/14, 00:12

    Backport for 6.2 missing. :-(