Review main Merged Breaking

34829[!!!][TASK] Drop include_once array functionality for modules

Wouter Wolters CR +2 V +2 Normal +45 −132 updated 01/01/15, 21:02

Commit message

The include_once array inside module functions is obsolete
and removed. The autoloader should be used instead.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Benni Mack +1
  • Verified V +2
    • Helmut Hummel +2
    • Benni Mack +1

Issues 1

Files 17

Review log 10

  1. Wouter Wolters uploaded patch set 1 11/30/14, 19:55

  2. Wouter Wolters commented on patch set 1 CR -2 11/30/14, 19:56

    RST file is missing
  3. Jigal van Hemert commented on patch set 1 11/30/14, 20:09

    What is the deprecation strategy here? In various places it says that it was deprecated in 6.2; can we remove it in 7 then?
  4. Helmut Hummel commented on patch set 1 11/30/14, 23:27

    @jigal yes, we can. only we need to properly document it with a rst cahngelog file
  5. Benni Mack updated the commit message in patch set 2 12/08/14, 20:34

  6. Benni Mack uploaded patch set 3 01/01/15, 09:56

  7. Benni Mack voted on patch set 3 CR +1 V +1 01/01/15, 09:57

  8. Wouter Wolters voted on patch set 3 CR 0 01/01/15, 17:58

  9. Helmut Hummel voted on patch set 3 CR +2 V +2 01/01/15, 21:02

  10. Helmut Hummel merged patch set 3 01/01/15, 21:02