Review main Merged

34838[TASK] Remove usage of deprecated showClickmenu_raw

Wouter Wolters CR +2 V +2 Easy +3 −3 updated 12/07/14, 16:13

Commit message

The JavaScript function showClickmenu_raw is deprecated
but still used in the core. Replace it with the new API.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Issues 1

Files 1

Review log 7

  1. Wouter Wolters uploaded patch set 1 11/30/14, 22:08

  2. Markus Klein voted on patch set 1 CR +1 11/30/14, 22:22

  3. Helmut Hummel commented on patch set 1 11/30/14, 23:22

    ClickMenu.php:308

    can we add quoteJSvalue, while we're at it?

    ClickMenu.php:514

    same here

    ClickMenu.php:998

    same here
  4. Wouter Wolters uploaded patch set 2 12/03/14, 16:23

  5. Markus Klein voted on patch set 2 CR +1 V +1 12/03/14, 20:02

  6. Stefan Neufeind voted on patch set 2 CR +2 V +2 12/07/14, 16:13

  7. Stefan Neufeind merged patch set 2 12/07/14, 16:13