Review main Merged

34884[TASK] Add missing htmlspecialchars() or quoteJSvalue() in ToolbarItems

Wouter Wolters CR +2 V +2 Easy +25 −25 updated 12/03/14, 19:58

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Helmut Hummel +2
  • Verified V +2
    • Markus Klein +2
    • Helmut Hummel +2

Issues 1

Files 3

Review log 11

  1. Wouter Wolters uploaded patch set 1 12/01/14, 17:56

  2. Stefan Neufeind voted on patch set 1 CR +1 12/01/14, 18:18

  3. Markus Klein commented on patch set 1 12/01/14, 18:38

    HelpToolbarItem.php:81

    IMO hsc is missing everywhere here
  4. Stefan Neufeind commented on patch set 1 CR -1 12/01/14, 19:26

    seems there might be some more missing hsc's

    HelpToolbarItem.php:81 Reply

    you're right I guess
  5. Helmut Hummel commented on patch set 1 12/03/14, 18:19

    HelpToolbarItem.php:81 Reply

    yeah, thanks. should also be added now

    UserToolbarItem.php:93

    same here
  6. Wouter Wolters uploaded patch set 2 12/03/14, 18:24

  7. Helmut Hummel uploaded patch set 3 12/03/14, 18:40

  8. Helmut Hummel voted on patch set 3 CR +2 12/03/14, 18:40

  9. Helmut Hummel voted on patch set 3 V +2 12/03/14, 18:43

  10. Markus Klein voted on patch set 3 CR +2 V +2 12/03/14, 19:58

  11. Markus Klein merged patch set 3 12/03/14, 19:58