34884[TASK] Add missing htmlspecialchars() or quoteJSvalue() in ToolbarItems
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Helmut Hummel +2
-
Verified V +2
- Markus Klein +2
- Helmut Hummel +2
Issues 1
Files 3
Review log 11
-
Wouter Wolters uploaded patch set 1 12/01/14, 17:56
-
Stefan Neufeind voted on patch set 1 CR +1 12/01/14, 18:18
-
Markus Klein commented on patch set 1 12/01/14, 18:38
-
Stefan Neufeind commented on patch set 1 CR -1 12/01/14, 19:26
seems there might be some more missing hsc'sHelpToolbarItem.php:81Replyyou're right I guess -
Helmut Hummel commented on patch set 1 12/03/14, 18:19
HelpToolbarItem.php:81Replyyeah, thanks. should also be added nowUserToolbarItem.php:93same here -
Wouter Wolters uploaded patch set 2 12/03/14, 18:24
-
Helmut Hummel uploaded patch set 3 12/03/14, 18:40
-
Helmut Hummel voted on patch set 3 CR +2 12/03/14, 18:40
-
Helmut Hummel voted on patch set 3 V +2 12/03/14, 18:43
-
Markus Klein voted on patch set 3 CR +2 V +2 12/03/14, 19:58
-
Markus Klein merged patch set 3 12/03/14, 19:58
HelpToolbarItem.php:81