34893[TASK] Update dataTables to 1.10.4 and fix parameter names
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
-
Verified V +2
- Stefan Neufeind +2
Issues 1
Files 5
- typo3/contrib/jquery/jquery.dataTables.min.js+155 −153
- typo3/sysext/documentation/Resources/Public/JavaScript/main.js+11 −19
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/main.js+10 −14
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/ter.js+30 −43
- typo3/sysext/lang/Resources/Public/JavaScript/LangModule.js+10 −14
Review log 10
-
Wouter Wolters uploaded patch set 1 12/01/14, 21:35
-
Stefan Neufeind commented on patch set 1 CR +1 12/01/14, 21:48
Fine by reading. Checked that parameters are renamed according to https://datatables.net/upgrade/1.10-convert -
Stefan Neufeind updated the commit message in patch set 2 12/01/14, 21:49
-
Stefan Neufeind commented on patch set 2 CR +1 12/01/14, 21:49
just removed a newline in commit-msg -
Stefan Neufeind commented on patch set 2 CR +2 V +2 12/01/14, 21:56
Works for me and parameter-substitutions look fine as well. -
Stefan Neufeind merged patch set 2 12/01/14, 21:56
-
Markus Klein commented on patch set 3 12/02/14, 00:53
Post -1. EM fails to download exts Follow up https://review.typo3.org/34897 fixes this -
Felix Kopp commented on patch set 3 12/02/14, 14:36
Post -1. Should not be merged for 7.0 since 1.9.x to 1.1.x is a huge step and nothing should be changed in stabilization phase :( -
Wouter Wolters commented on patch set 3 12/02/14, 14:52
Felix, this a upgrade from 1.10.2 to 1.10.4. Nothing is wrong here. -
Felix Kopp commented on patch set 3 12/02/14, 15:06
Sorry, misread!! I was convinced 1.9 to 1.10. Pardon me