Review main Merged

34893[TASK] Update dataTables to 1.10.4 and fix parameter names

Wouter Wolters CR +2 V +2 Hard +216 −243 updated 12/02/14, 15:06

Commit message

In 1.10 version the parameter names need to be converted to
their new names. See http://datatables.net/upgrade/1.10-convert

fnCookieCallback is removed without substiution. Therefore
removed in this patch.

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 5

Review log 10

  1. Wouter Wolters uploaded patch set 1 12/01/14, 21:35

  2. Stefan Neufeind commented on patch set 1 CR +1 12/01/14, 21:48

    Fine by reading. Checked that parameters are renamed according to https://datatables.net/upgrade/1.10-convert
  3. Stefan Neufeind updated the commit message in patch set 2 12/01/14, 21:49

  4. Stefan Neufeind commented on patch set 2 CR +1 12/01/14, 21:49

    just removed a newline in commit-msg
  5. Stefan Neufeind commented on patch set 2 CR +2 V +2 12/01/14, 21:56

    Works for me and parameter-substitutions look fine as well.
  6. Stefan Neufeind merged patch set 2 12/01/14, 21:56

  7. Markus Klein commented on patch set 3 12/02/14, 00:53

    Post -1. EM fails to download exts Follow up https://review.typo3.org/34897 fixes this
  8. Felix Kopp commented on patch set 3 12/02/14, 14:36

    Post -1. Should not be merged for 7.0 since 1.9.x to 1.1.x is a huge step and nothing should be changed in stabilization phase :(
  9. Wouter Wolters commented on patch set 3 12/02/14, 14:52

    Felix, this a upgrade from 1.10.2 to 1.10.4. Nothing is wrong here.
  10. Felix Kopp commented on patch set 3 12/02/14, 15:06

    Sorry, misread!! I was convinced 1.9 to 1.10. Pardon me