Review main Merged

34897[TASK] Followup: Update dataTables to 1.10.4 and fix parameter names

Stefan Neufeind CR +2 V +2 Easy +12 −12 updated 12/02/14, 01:01

Commit message

Use DataTables instead of dataTables to access the API.
Also switch to the new API.
https://datatables.net/reference/api/

Followup to change-id If564b1797a81ce63730ebf2601cc62058940493c

Review

  • Code review CR +2
    • Markus Klein +2
    • Christoph Hofmann +1
  • Verified V +2
    • Markus Klein +2
    • Christoph Hofmann +1

Issues 1

Files 4

Review log 5

  1. Stefan Neufeind uploaded patch set 1 12/01/14, 22:54

  2. Stefan Neufeind commented on patch set 1 12/01/14, 22:56

    In EXT:documentation the clearable-icon for the search doesn't work for me. It seems to call search(''), but that doesn't clear anything. The API in the variable looks okay though. And I'm unsure how to trigger the getVars['search']-things.
  3. Christoph Hofmann voted on patch set 1 CR +1 V +1 12/02/14, 00:36

  4. Markus Klein voted on patch set 1 CR +2 V +2 12/02/14, 00:56

  5. Markus Klein merged patch set 1 12/02/14, 01:01