Review main Merged

34945[TASK] Use panels for "Template" configuration

Soren Malling CR +2 V +2 Easy +6 −2 updated 12/02/14, 23:22

Commit message

Use panel-* classes from Twitter Bootstrap
to give a better look and feel when browsing
the typoscript tree

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 7

  1. Soren Malling uploaded patch set 1 12/02/14, 18:17

  2. Michael Oehlhof commented on patch set 1 CR -1 12/02/14, 22:40

    410-413: Wrong Indentations. Indentation is to be used inside control structures and for breaking overlong lines and not for showing the nesting of the variable content.
  3. Felix Kopp commented on patch set 1 V +1 12/02/14, 22:58

    Great improvement for the module!
  4. Markus Klein uploaded patch set 2 12/02/14, 23:07

  5. Markus Klein voted on patch set 2 CR +1 V +1 12/02/14, 23:08

  6. Wouter Wolters commented on patch set 2 V +2 CR +2 12/02/14, 23:22

    Felix verified, only a cosmetic change in indentation.
  7. Wouter Wolters merged patch set 2 12/02/14, 23:22