Review main Merged

34946[BUGFIX] Cannot uninstall packages with dependencies in install tool

Oliver Hader CR +2 V +2 Easy +11 −0 updated 12/02/14, 19:56

Commit message

Scenario:
* upgrading from Introcuction Package with TYPO3 CMS 6.2
  to TYPO3 CMS 7
* realurl is marked as incompatible extension to be uninstalled
* realurl is a dependency of bootstrap_package which itself is
  dependency of introduction

Result:
* resolving the dependencies does not work and thus the uninstall
  process for realurl fails as well

Solution:
* check whether extension to be removed is a dependency of some
  other extension
* if so, first remove that extension and afterwards to original
  extension

Review

  • Code review CR +2
    • Markus Klein +2
    • Anja Leichsenring +1
  • Verified V +2
    • Oliver Hader +2
    • Markus Klein +1
    • Anja Leichsenring +1

Issues 1

Files 1

Review log 9

  1. Oliver Hader uploaded patch set 1 12/02/14, 18:26

  2. Markus Klein updated the commit message in patch set 2 12/02/14, 18:29

  3. Markus Klein voted on patch set 2 CR +1 12/02/14, 18:35

  4. Markus Klein voted on patch set 2 CR +2 V +1 12/02/14, 18:37

  5. Anja Leichsenring voted on patch set 2 CR +1 V +1 12/02/14, 18:38

  6. Oliver Hader voted on patch set 2 V +2 12/02/14, 18:40

  7. Oliver Hader merged patch set 2 12/02/14, 18:40

  8. Christian Kuhn commented on patch set 3 12/02/14, 19:31

    sure this works in em? em has an own dependency check during uninstall - this may easily lead to regressions if another check is now done lowlevel in packagemanager at first glance.
  9. Markus Klein commented on patch set 3 12/02/14, 19:56

    @Christian: I tested this with a set of my dependency test-exts I used to construct the DependencyResolver. Worked out without problems. The EM is even more restrictive. It forbids to deactivate an ext if another one depends on it, so the recursive deactivation is never triggered. Actually this approach is now really nice, since we can do recursive deactivation programmatically, but the user can't.