34947[BUGFIX] Tasks Center section menu is hardcoded
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Benni Mack +1
-
Verified V +2
- Markus Klein +2
- Benni Mack +1
Issues 1
Files 2
Review log 28
Show 3 earlier messages
-
Philipp Gampe uploaded patch set 1 12/02/14, 18:45
-
Benni Mack commented on patch set 1 12/02/14, 19:24
Very nice one. How about migrating to "functions" instead (I did the same with "wiz" in Web=>Functions=>Wizards) and depreacte "mode" in the future, but merge "mode" elements into "functions"? -
Philipp Gampe commented on patch set 1 12/02/14, 20:35
TaskModuleController.php:65I guess this needs to be 'mode' to.
-
Philipp Gampe commented on patch set 1 V +1 12/02/14, 20:42
does not work any more -
Philipp Gampe voted on patch set 1 V -1 12/02/14, 20:42
-
Philipp Gampe uploaded patch set 2 12/02/14, 20:45
-
Philipp Gampe commented on patch set 2 12/02/14, 20:47
@Benni, function is already used for the individual tasks. This we have a mode 'tasks' with several functions inside it. Maybe we should remove this logic and make to dedicated views 'information' and 'tasks' and render only a single tasks at time. However this is not the way the Task Center works currently. I do not really use the Task Center, thus I cannot say how this should be done best. I only reacted to a question in typo3.german. -
Mathias Schreiber wrote 12/17/14, 14:33
Topic set to EXT: taskcenter -
Benni Mack voted on patch set 2 CR +1 01/05/15, 13:17
-
Markus Klein rebased onto patch set 2 01/05/15, 14:13
-
Markus Klein commented on patch set 3 CR -1 01/05/15, 14:16
TaskModuleController.php:73moduleNameTaskModuleController.php:76We still need to call the parent here as we disable tsconfig handling for functions otherwise. -
Christian Kuhn commented on patch set 3 06/05/15, 16:52
ping. imho this one could be finished. -
Philipp Gampe uploaded patch set 4 06/08/15, 11:06
-
Philipp Gampe commented on patch set 3 06/08/15, 11:07
TaskModuleController.php:73ReplyDoneTaskModuleController.php:76ReplyDone -
Philipp Gampe commented on patch set 4 06/08/15, 11:08
adopted patch to new code style and changes around (getter for globals) the current code added call to parent -
Markus Klein commented on patch set 4 06/08/15, 11:38
TaskModuleController.php:81moduleName -
Philipp Gampe commented on patch set 4 06/08/15, 18:29
TaskModuleController.php:81ReplyDone -
Philipp Gampe uploaded patch set 6 06/08/15, 18:34
-
Philipp Gampe commented on patch set 6 06/08/15, 18:35
LOL: patchset 5 just disappeared :( (server error). I had to change the commit message slightly to trigger a new commit in order to allow me to push again :/ -
Markus Klein voted on patch set 6 CR +1 06/08/15, 18:51
-
Pierrick Caillon commented on patch set 6 06/15/15, 14:41
TaskModuleController.php:79Is it still needed to explicitly make the getModuleData call? It is done in the parent::menuConfig(). -
Philipp Gampe commented on patch set 6 06/16/15, 06:24
TaskModuleController.php:79ReplyNot sure here ... please try that and test if menu creation and blinding of items still works if you remove the call. -
Philipp Gampe uploaded patch set 7 06/16/15, 06:35
-
Philipp Gampe commented on patch set 7 06/16/15, 06:36
Just tried this and it works if removing the call, thus I simplified the patch further by removing the mentioned call. -
Benni Mack updated the commit message in patch set 8 06/20/15, 10:42
-
Benni Mack voted on patch set 8 CR +1 V +1 06/20/15, 10:42
-
Markus Klein voted on patch set 8 CR +2 V +2 06/21/15, 21:51
-
Markus Klein merged patch set 8 06/21/15, 21:51