Review main Merged

34947[BUGFIX] Tasks Center section menu is hardcoded

Philipp Gampe CR +2 V +2 Easy +12 −1 updated 06/21/15, 21:51

Commit message

Since the refactoring of the tasks center in 4.5, the section menu is
hardcoded to information and tasks and cannot be changed.

This is because the menu items are collected inside the array key 'mode'
instead of 'function'.
Because 'function' is hardcoded in the logic of BaseScriptClass, copy
the four lines from BaseScriptClass instead of calling
parent:menu_config() in the TaskModuleController.

Additionally, 'Tasks' is hardcoded as a label. Replace it with a
localized value.

Note: 'function' is preserved for backward compatibility and is already
in use for the main tasks logic.

Use page.mod.user_task.menu.mode.information = 0 to blind an individual
item, e.g. information.

Some further code cleanups are included.

Review

  • Code review CR +2
    • Markus Klein +2
    • Benni Mack +1
  • Verified V +2
    • Markus Klein +2
    • Benni Mack +1

Issues 1

Files 2

Review log 28

Show 3 earlier messages
  1. Philipp Gampe uploaded patch set 1 12/02/14, 18:45

  2. Benni Mack commented on patch set 1 12/02/14, 19:24

    Very nice one. How about migrating to "functions" instead (I did the same with "wiz" in Web=>Functions=>Wizards) and depreacte "mode" in the future, but merge "mode" elements into "functions"?
  3. Philipp Gampe commented on patch set 1 12/02/14, 20:35

    TaskModuleController.php:65

    I guess this needs to be 'mode' to.
  1. Philipp Gampe commented on patch set 1 V +1 12/02/14, 20:42

    does not work any more
  2. Philipp Gampe voted on patch set 1 V -1 12/02/14, 20:42

  3. Philipp Gampe uploaded patch set 2 12/02/14, 20:45

  4. Philipp Gampe commented on patch set 2 12/02/14, 20:47

    @Benni, function is already used for the individual tasks. This we have a mode 'tasks' with several functions inside it. Maybe we should remove this logic and make to dedicated views 'information' and 'tasks' and render only a single tasks at time. However this is not the way the Task Center works currently. I do not really use the Task Center, thus I cannot say how this should be done best. I only reacted to a question in typo3.german.
  5. Mathias Schreiber wrote 12/17/14, 14:33

    Topic set to EXT: taskcenter
  6. Benni Mack voted on patch set 2 CR +1 01/05/15, 13:17

  7. Markus Klein rebased onto patch set 2 01/05/15, 14:13

  8. Markus Klein commented on patch set 3 CR -1 01/05/15, 14:16

    TaskModuleController.php:73

    moduleName

    TaskModuleController.php:76

    We still need to call the parent here as we disable tsconfig handling for functions otherwise.
  9. Christian Kuhn commented on patch set 3 06/05/15, 16:52

    ping. imho this one could be finished.
  10. Philipp Gampe uploaded patch set 4 06/08/15, 11:06

  11. Philipp Gampe commented on patch set 3 06/08/15, 11:07

    TaskModuleController.php:73 Reply

    Done

    TaskModuleController.php:76 Reply

    Done
  12. Philipp Gampe commented on patch set 4 06/08/15, 11:08

    adopted patch to new code style and changes around (getter for globals) the current code added call to parent
  13. Markus Klein commented on patch set 4 06/08/15, 11:38

    TaskModuleController.php:81

    moduleName
  14. Philipp Gampe commented on patch set 4 06/08/15, 18:29

    TaskModuleController.php:81 Reply

    Done
  15. Philipp Gampe uploaded patch set 6 06/08/15, 18:34

  16. Philipp Gampe commented on patch set 6 06/08/15, 18:35

    LOL: patchset 5 just disappeared :( (server error). I had to change the commit message slightly to trigger a new commit in order to allow me to push again :/
  17. Markus Klein voted on patch set 6 CR +1 06/08/15, 18:51

  18. Pierrick Caillon commented on patch set 6 06/15/15, 14:41

    TaskModuleController.php:79

    Is it still needed to explicitly make the getModuleData call? It is done in the parent::menuConfig().
  19. Philipp Gampe commented on patch set 6 06/16/15, 06:24

    TaskModuleController.php:79 Reply

    Not sure here ... please try that and test if menu creation and blinding of items still works if you remove the call.
  20. Philipp Gampe uploaded patch set 7 06/16/15, 06:35

  21. Philipp Gampe commented on patch set 7 06/16/15, 06:36

    Just tried this and it works if removing the call, thus I simplified the patch further by removing the mentioned call.
  22. Benni Mack updated the commit message in patch set 8 06/20/15, 10:42

  23. Benni Mack voted on patch set 8 CR +1 V +1 06/20/15, 10:42

  24. Markus Klein voted on patch set 8 CR +2 V +2 06/21/15, 21:51

  25. Markus Klein merged patch set 8 06/21/15, 21:51