Review main Merged

34974[BUGFIX] Enriched relation values in rootline do not consider overlays

Jonas Enders CR +2 V +2 Normal +10 −68 updated 11/04/21, 15:05

Commit message

The overlay handling (localization and workspaces) of relation values
resolved in the RootlineUtility do only consider the live workspace.
Values from other draft workspaces may work by accident, however the
handling there is incomplete towards relations and the processing of
the combined localization and version chain.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 4455

Show 2630 earlier messages
  1. Jonas Enders uploaded patch set 1 12/03/14, 12:24

  2. Mathias Schreiber wrote 12/17/14, 20:36

    Topic set to Core Utility
  3. Andreas Wolf uploaded patch set 2 07/16/15, 09:33

  4. Andreas Wolf commented on patch set 1 07/16/15, 09:34

    Jonas, thanks for your contribution, and sorry for the delay. I just rebased the patch to a recent version and will now try to reproduce the problem and vote for the patch.
  5. Tomas Norre Mikkelsen voted on patch set 2 CR +1 07/31/15, 12:17

  6. Benni Mack wrote 08/12/15, 20:20

    Topic changed from Core Utility to workspaces
  7. Oliver Hader uploaded patch set 3 10/09/15, 06:31

  8. Tomas Norre Mikkelsen voted on patch set 3 CR +1 10/23/15, 13:41

  9. Oliver Hader commented on patch set 3 10/27/15, 14:37

    Can you please describe in the commit message what this change is all about and why the change für media relations is required in the RootlineUtility? Thx
  10. Oliver Hader commented on patch set 3 CR -1 12/01/15, 16:09

    Working on it...
  11. Oliver Hader commented on patch set 3 12/01/15, 17:47

    The current RootlineUtility in the core is a mess... sys_language_uid is not set property at the time the rootline is created and the field magic happens
  12. Oliver Hader uploaded patch set 4 12/01/15, 23:32

  13. Oliver Hader uploaded patch set 5 12/01/15, 23:42

  14. Oliver Hader commented on patch set 5 12/01/15, 23:45

    Concerning functionality I thinks that's ready (functional tests could be great to resolve the "I think" part). However, there are still some coding flaws which are just introduced to let the RootlineUtility know that everything (context, workspace, language) has been initialized and the the real results can be determined. The implementation prior to this change is somehow really, really flaky...
  15. Oliver Hader commented on patch set 5 CR -1 12/02/15, 12:23

    Still working on it...
  16. Oliver Hader uploaded patch set 6 12/02/15, 12:41

  17. Mona Muzaffar commented on patch set 6 02/24/17, 15:28

    is someone still working on this patch, or can it be closed?
  18. Benni Mack commented on patch set 6 11/29/17, 00:20

    Oliver, this one is for you!
  19. Reiner Teubner uploaded patch set 7 02/07/18, 12:07

  20. Reiner Teubner commented on patch set 7 02/07/18, 12:07

    rebase merge conflict
  21. TYPO3com voted on patch set 7 V -1 02/07/18, 12:15 Completed build in 08m 06s on Wed, 7 Feb, 01:15 PM Test Summary: 1425 of 30613 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19071

  22. Mathias Schreiber commented on patch set 7 CR -1 02/07/18, 15:47

    rebase went south... we need to understand the idea of the code in the first place.
  23. Benni Mack commented on patch set 7 09/04/18, 06:07

    This patch is valuable, as it resolves todos, but we can make that better now, would be great to have somebody pick that up and fix it.
  24. Benni Mack uploaded patch set 8 10/29/18, 09:27

  25. TYPO3com voted on patch set 8 V +1 10/29/18, 09:40 Completed build in 12m 49s on Mon, 29 Oct, 10:40 AM Test Summary: 38167 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29803

  26. Oliver Hader commented on patch set 8 11/19/18, 12:56

    I would not extend RelationHandler further - it basically is bound to DataHandler. Using it in different scenarios (at lot in the core) is the first flaw in architecture... I'd rather use some™ other wrapper/method that forwards these settings to PlainDataResolver
  27. Oliver Hader rebased onto patch set 9 01/30/19, 16:08

  28. TYPO3com voted on patch set 9 V +1 01/30/19, 16:35 Completed build in 27m 04s on Wed, 30 Jan, 05:35 PM Test Summary: 46898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31844

  29. Benni Mack uploaded patch set 10 09/26/19, 11:56

  30. TYPO3com voted on patch set 10 V +1 09/26/19, 12:06 Completed build in 09m 34s on Thu, 26 Sep, 12:06 PM Test Summary: 47728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36859

  1. Andreas Kienast commented on patch set 10 V -1 09/26/19, 12:28

    I've tested it by using the pages.media field, it's only partially fixed. The live version keeps the correct reference, the workspace version crashes with `No file reference (sys_file_reference) was found for given UID: "XXX"`. Before the patch, both versions crash with that message.
  2. Andreas Kienast commented on patch set 10 V +1 CR +1 09/26/19, 14:35

    The issue is not related to this patch, there's something wrong in FrontendRestrictionContainer.
  3. Andreas Kienast commented on patch set 10 CR -1 09/27/19, 08:17

    on it
  4. Andreas Kienast uploaded patch set 11 09/27/19, 09:22

  5. Andreas Kienast uploaded patch set 12 09/27/19, 09:32

  6. TYPO3com voted on patch set 11 V -1 09/27/19, 09:33 Completed build in 10m 32s on Fri, 27 Sep, 09:33 AM Test Summary: 1 of 48075 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36872

  7. TYPO3com voted on patch set 12 V +1 09/27/19, 09:43 Completed build in 10m 53s on Fri, 27 Sep, 09:43 AM Test Summary: 47716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36873

  8. Benni Mack uploaded patch set 13 04/17/20, 23:20

  9. TYPO3com voted on patch set 13 V +1 04/17/20, 23:35 Completed build in 14m 10s on Fri, 17 Apr, 11:35 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2766

  10. Benni Mack voted on patch set 13 CR +1 06/04/20, 19:51

  11. Christian Kuhn commented on patch set 13 10/28/20, 15:51

    RootlineUtility.php:289

    Note: This misses the workspace setting. However, MM in workspaces has a series of other issues that need to be fixed first, before we can have a look at the frontend ...

    RootlineUtility.php:310

    Yes. Should work. However, it would be much better if we would just fetch relations from sys_refindex - this would be 1 query for all fields. We should switch to this (at least in master) as soon as MM relations stuff with sys_refindex is fixed.
  12. Christian Kuhn commented on patch set 13 10/28/20, 17:27

    Well yes, the patch looks good on reading. However, I'm unable to reproduce an issue in workspaces without the patch. Debugging shows that relations (on field page:media) are resolved correctly in workspaces ... maybe the bug resolved with the pid=-1 change in v10?
  13. Christian Kuhn commented on patch set 13 V -1 10/29/20, 10:20

    Ok, I'll -1 the patch for now since I'm unable to reproduce an bug in current master at the moment without patch. We'll keep the patch pending for now, though. I'll set the issue to 'needs feedback' ... if there are still issues, please add a good 'how to reproduce' to the issue.
  14. Benni Mack uploaded patch set 14 07/29/21, 19:39

  15. core-ci voted on patch set 14 V -1 07/29/21, 19:49 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13899

  16. Benni Mack uploaded patch set 15 07/29/21, 21:31

  17. core-ci voted on patch set 15 V +1 07/29/21, 21:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13908

  18. Benni Mack uploaded patch set 16 11/04/21, 14:08

  19. core-ci voted on patch set 16 V +1 11/04/21, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18889

  20. Christian Kuhn uploaded patch set 17 11/04/21, 14:39

  21. Christian Kuhn commented on patch set 17 V +1 CR +1 11/04/21, 14:39

    RootlineUtility.php:289 Reply

    Done

    RootlineUtility.php:310 Reply

    Done
  22. Benni Mack voted on patch set 17 V +1 CR +1 11/04/21, 14:41

  23. core-ci voted on patch set 17 V +1 11/04/21, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18892

  24. Benni Mack voted on patch set 17 V +2 CR +2 11/04/21, 15:05

  25. Benni Mack merged patch set 18 11/04/21, 15:05