Review main Merged

34985[TASK] Remove unselected languages in LocalConfiguration

Andreas Kienast CR +2 V +2 Easy +5 −6 updated 12/03/14, 20:09

Commit message

If selecting one ore more languages in EXT:lang, the complete
language tree is written in EXTCONF/lang/availableLanguages in
LocalConfiguration.php. Empty values in this array represent
unselected languages. This patch removes the empty values
from the language array.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +2

Issues 1

Files 2

Review log 10

  1. Andreas Kienast uploaded patch set 1 12/03/14, 15:05

  2. Andreas Kienast uploaded patch set 2 12/03/14, 15:10

  3. Helmut Hummel commented on patch set 2 12/03/14, 15:15

    nice one. Wanna add a unit test for this?
  4. Andreas Kienast uploaded patch set 3 12/03/14, 15:52

  5. Wouter Wolters voted on patch set 3 V +2 CR +1 12/03/14, 16:17

  6. Markus Klein commented on patch set 3 CR -1 12/03/14, 20:08

    language updating seems to not work anymore
  7. Markus Klein voted on patch set 3 V -1 12/03/14, 20:08

  8. Markus Klein commented on patch set 3 CR +2 V +2 12/03/14, 20:09

    strange now it's working
  9. Markus Klein merged patch set 3 12/03/14, 20:09

  10. Markus Klein commented on patch set 4 12/03/14, 20:09

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit d3275d2225ebeb478d14c7e4800bdb9b4797dc4b