Review main Merged

35005[BUGFIX] objectManager->create is removed but still in use

Wouter Wolters CR +2 V +2 Easy +2 −2 updated 12/03/14, 23:21

Commit message

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +2
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +2

Issues 1

Files 2

Review log 8

  1. Wouter Wolters uploaded patch set 1 12/03/14, 18:47

  2. Wouter Wolters rebased onto patch set 1 12/03/14, 18:47

  3. Wouter Wolters uploaded patch set 3 12/03/14, 18:48

  4. Stefan Neufeind commented on patch set 3 CR +2 V +2 12/03/14, 22:52

    * verified that the change in PreviewController works as expected * searched for for other uses of create() (for the object-manager) with no more matches than patched here * verified in deprecation-notice/code from 6.2 that get() is a straight replacement for create()
  5. Stefan Neufeind commented on patch set 3 12/03/14, 22:54

    note for a possible "known bugs"-list: Workspace-preview broken in 7.0 *sigh*
  6. Markus Klein voted on patch set 3 CR +2 V +2 12/03/14, 23:20

  7. Markus Klein merged patch set 3 12/03/14, 23:20

  8. Markus Klein commented on patch set 4 12/03/14, 23:21

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 49662be04db67b02160174cd3960fa3f21ffd1a9