Review main Merged

35020[BUGFIX] Skip updates if InitialUpdateDatabaseSchema is needed

Markus Klein CR +2 V +2 Easy +4 −0 updated 01/16/15, 20:14

Commit message

In case the InitialUpdateDatabaseSchema needs to add fields
to the database, we must not run any checks (like checkForUpdate)
of other updates, since they may require a new field to
be present already in the database, which would lead to
SQL errors.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1

Issues 1

Files 1

Review log 10

  1. Markus Klein uploaded patch set 1 12/04/14, 01:34

  2. Markus Klein commented on patch set 1 12/04/14, 01:36

  3. Mathias Schreiber wrote 12/17/14, 14:33

    Topic set to EXT: install
  4. Benni Mack voted on patch set 1 CR +1 01/08/15, 20:33

  5. Benni Mack commented on patch set 1 V +1 01/08/15, 20:35

    although you cannot run any other wizards if this one is not called, I'm fine either way.
  6. Markus Klein commented on patch set 1 01/08/15, 21:22

    That's the whole point of the story. You MUST NOT run any wizard if DB is not in shape for the wizard. That's why this specific wizard has topmost priority.
  7. Markus Klein commented on patch set 1 01/10/15, 22:21

    ping
  8. Markus Klein commented on patch set 1 01/15/15, 00:36

    ping!
  9. Wouter Wolters voted on patch set 1 V +2 CR +2 01/16/15, 20:14

  10. Wouter Wolters merged patch set 1 01/16/15, 20:14