Review main Merged

35029[FEATURE] Add stdWrap strtotime

Mathias Brodala CR +2 V +2 Normal +129 −0 updated 04/28/15, 11:38

Commit message

This allows for conversion of formatted dates to timestamp and
complements the existing date/strftime properties.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Georg Ringer +1
    • Jo Hasenau +1
    • Markus Klein +1
  • Verified V +2
    • Andreas Kienast +2
    • Georg Ringer +1
    • Jo Hasenau +1

Issues 1

Files 3

Review log 30

Show 5 earlier messages
  1. Mathias Brodala uploaded patch set 1 12/04/14, 11:33

  2. Mathias Brodala uploaded patch set 2 12/04/14, 11:34

  3. Markus Klein commented on patch set 2 12/04/14, 11:44

    ContentObjectRenderer.php:2845

    no need for $content, return directly
  4. Mathias Brodala uploaded patch set 3 12/04/14, 11:59

  5. Mathias Brodala commented on patch set 3 CR -1 12/04/14, 12:20

    I'll change this slightly to allow for "strtotime = 1" to convert any input value to timestamp without modification.
  1. Mathias Brodala uploaded patch set 4 12/04/14, 13:06

  2. Markus Klein commented on patch set 4 12/04/14, 20:53

    Can you please add some unit tests for this function? Thanks a lot
  3. Lukas Krieger commented on patch set 4 12/08/14, 03:10

    this feature is nice, need the exact same functionality and do not want to add user php for such a small manipulation. especially helpful for using third party dates
  4. Mathias Brodala rebased onto patch set 4 12/08/14, 08:50

  5. Mathias Brodala uploaded patch set 6 12/08/14, 09:42

  6. Mathias Brodala commented on patch set 6 CR -1 12/08/14, 09:43

    See question wrt empty input.

    ContentObjectRendererTest.php:1571

    Do we want a different handling here like returning the current timestamp instead?
  7. Mathias Brodala commented on patch set 6 CR 0 01/23/15, 11:10

    Unblocking myself.
  8. Mathias Brodala rebased onto patch set 6 01/23/15, 11:10

  9. Benni Mack commented on patch set 7 01/26/15, 18:08

    Hey, shouldn't this function go BEFORE date. as well? Otherwise strftime is the only function benefiting from that.
  10. Mathias Brodala commented on patch set 7 01/27/15, 06:56

    @Benjamin: No, otherwise the use case 1. get timestamp via date, 2. format timestamp wouldn't work.
  11. Stefan Neufeind commented on patch set 7 02/03/15, 10:23

    So where do we put it? Would be nice to revive this review.
  12. Frederic Gaus voted on patch set 7 CR +1 02/03/15, 20:50

  13. Mathias Brodala uploaded patch set 8 04/01/15, 06:58

  14. Mathias Brodala uploaded patch set 9 04/01/15, 07:04

  15. Mathias Brodala uploaded patch set 10 04/02/15, 12:30

  16. Mathias Brodala wrote 04/14/15, 14:43

    Topic set to cObj
  17. Markus Klein commented on patch set 10 04/14/15, 14:45

    ContentObjectRenderer.php:2949

    The rst is missing the description and a usage example. This is important for updating TSref!
  18. Mathias Brodala commented on patch set 10 04/15/15, 06:51

    ContentObjectRenderer.php:2949 Reply

    Done
  19. Mathias Brodala uploaded patch set 11 04/15/15, 06:51

  20. Markus Klein voted on patch set 11 CR +1 04/15/15, 08:24

  21. Georg Ringer voted on patch set 11 CR +1 V +1 04/16/15, 12:54

  22. Jo Hasenau voted on patch set 11 V +1 CR +1 04/23/15, 10:46

  23. Andreas Kienast commented on patch set 11 CR -2 04/23/15, 11:18

    Blocked until next merge window.
  24. Andreas Kienast voted on patch set 11 CR +2 V +2 04/28/15, 11:38

  25. Andreas Kienast merged patch set 11 04/28/15, 11:38