35029[FEATURE] Add stdWrap strtotime
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Georg Ringer +1
- Jo Hasenau +1
- Markus Klein +1
-
Verified V +2
- Andreas Kienast +2
- Georg Ringer +1
- Jo Hasenau +1
Issues 1
Files 3
Review log 30
Show 5 earlier messages
-
Mathias Brodala uploaded patch set 1 12/04/14, 11:33
-
Mathias Brodala uploaded patch set 2 12/04/14, 11:34
-
Markus Klein commented on patch set 2 12/04/14, 11:44
-
Mathias Brodala uploaded patch set 3 12/04/14, 11:59
-
Mathias Brodala commented on patch set 3 CR -1 12/04/14, 12:20
I'll change this slightly to allow for "strtotime = 1" to convert any input value to timestamp without modification.
-
Mathias Brodala uploaded patch set 4 12/04/14, 13:06
-
Markus Klein commented on patch set 4 12/04/14, 20:53
Can you please add some unit tests for this function? Thanks a lot -
Lukas Krieger commented on patch set 4 12/08/14, 03:10
this feature is nice, need the exact same functionality and do not want to add user php for such a small manipulation. especially helpful for using third party dates -
Mathias Brodala rebased onto patch set 4 12/08/14, 08:50
-
Mathias Brodala uploaded patch set 6 12/08/14, 09:42
-
Mathias Brodala commented on patch set 6 CR -1 12/08/14, 09:43
See question wrt empty input.ContentObjectRendererTest.php:1571Do we want a different handling here like returning the current timestamp instead? -
Mathias Brodala commented on patch set 6 CR 0 01/23/15, 11:10
Unblocking myself. -
Mathias Brodala rebased onto patch set 6 01/23/15, 11:10
-
Benni Mack commented on patch set 7 01/26/15, 18:08
Hey, shouldn't this function go BEFORE date. as well? Otherwise strftime is the only function benefiting from that. -
Mathias Brodala commented on patch set 7 01/27/15, 06:56
@Benjamin: No, otherwise the use case 1. get timestamp via date, 2. format timestamp wouldn't work. -
Stefan Neufeind commented on patch set 7 02/03/15, 10:23
So where do we put it? Would be nice to revive this review. -
Frederic Gaus voted on patch set 7 CR +1 02/03/15, 20:50
-
Mathias Brodala uploaded patch set 8 04/01/15, 06:58
-
Mathias Brodala uploaded patch set 9 04/01/15, 07:04
-
Mathias Brodala uploaded patch set 10 04/02/15, 12:30
-
Mathias Brodala wrote 04/14/15, 14:43
Topic set to cObj -
Markus Klein commented on patch set 10 04/14/15, 14:45
ContentObjectRenderer.php:2949The rst is missing the description and a usage example. This is important for updating TSref! -
Mathias Brodala commented on patch set 10 04/15/15, 06:51
ContentObjectRenderer.php:2949ReplyDone -
Mathias Brodala uploaded patch set 11 04/15/15, 06:51
-
Markus Klein voted on patch set 11 CR +1 04/15/15, 08:24
-
Georg Ringer voted on patch set 11 CR +1 V +1 04/16/15, 12:54
-
Jo Hasenau voted on patch set 11 V +1 CR +1 04/23/15, 10:46
-
Andreas Kienast commented on patch set 11 CR -2 04/23/15, 11:18
Blocked until next merge window. -
Andreas Kienast voted on patch set 11 CR +2 V +2 04/28/15, 11:38
-
Andreas Kienast merged patch set 11 04/28/15, 11:38
ContentObjectRenderer.php:2845