35058[BUGFIX] Use die() instead of exception for PHP version check
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Alexander Opitz +1
- Wouter Wolters +1
-
Verified V +2
- Frank Nägler +2
- Alexander Opitz +1
- Wouter Wolters +1
Issues 1
Files 1
Review log 7
-
Markus Klein uploaded patch set 1 12/04/14, 22:01
-
Alexander Opitz commented on patch set 1 V +1 CR +1 12/04/14, 22:03
This should help on hosters which disable showing of errors. -
Wouter Wolters voted on patch set 1 V +1 CR +1 12/04/14, 22:06
-
Frank Nägler voted on patch set 1 V +2 CR +2 12/04/14, 22:19
-
Frank Nägler merged patch set 1 12/04/14, 22:20
-
Frans Saris commented on patch set 2 12/05/14, 21:10
Are we sure there is no code executed that requires PHP 5.5 before they arrive at this file? When they just try to open /typo3/install/ -
Markus Klein commented on patch set 2 12/06/14, 00:11
@Frans: typo3/install/ redirects to Start/Install.php, bootstrap does so too, but you'll never get there, since you need to install 7.x first, which should already trigger the die() stmt. So IMO this is fine.