Review main Merged

35058[BUGFIX] Use die() instead of exception for PHP version check

Markus Klein CR +2 V +2 Easy +1 −1 updated 12/06/14, 00:11

Commit message

The installer checks for the PHP version and throws and exception.
This is bad for people not having enabled display_errors in their
PHP config and leads to an empty white page.

Change this to simply die() as this will ensure the user can
see the cause of the issue.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Alexander Opitz +1
    • Wouter Wolters +1
  • Verified V +2
    • Frank Nägler +2
    • Alexander Opitz +1
    • Wouter Wolters +1

Issues 1

Files 1

Review log 7

  1. Markus Klein uploaded patch set 1 12/04/14, 22:01

  2. Alexander Opitz commented on patch set 1 V +1 CR +1 12/04/14, 22:03

    This should help on hosters which disable showing of errors.
  3. Wouter Wolters voted on patch set 1 V +1 CR +1 12/04/14, 22:06

  4. Frank Nägler voted on patch set 1 V +2 CR +2 12/04/14, 22:19

  5. Frank Nägler merged patch set 1 12/04/14, 22:20

  6. Frans Saris commented on patch set 2 12/05/14, 21:10

    Are we sure there is no code executed that requires PHP 5.5 before they arrive at this file? When they just try to open /typo3/install/
  7. Markus Klein commented on patch set 2 12/06/14, 00:11

    @Frans: typo3/install/ redirects to Start/Install.php, bootstrap does so too, but you'll never get there, since you need to install 7.x first, which should already trigger the die() stmt. So IMO this is fine.